Closed Bug 1645346 Opened 5 years ago Closed 5 years ago

[socket process] NS_ENSURE_TRUE(mState != STATE_IDLE) failed: file /builds/worker/checkouts/gecko/netwerk/base/nsInputStreamPump.cpp

Categories

(Core :: Networking, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

I've seen a lot of warning below.

[task 2020-06-10T19:52:59.746Z] 19:52:59     INFO - GECKO(1244) | [Socket 1273, Main Thread] WARNING: NS_ENSURE_TRUE(mState != STATE_IDLE) failed: file /builds/worker/checkouts/gecko/netwerk/base/nsInputStreamPump.cpp, line 226
[task 2020-06-10T19:52:59.746Z] 19:52:59     INFO - GECKO(1244) | [Socket 1273, Main Thread] WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed: file /builds/worker/checkouts/gecko/netwerk/base/nsInputStreamPump.cpp, line 236

The reason is that we usually suspend the transaction pump in in nsHttpChannel::OnStartRequest, but at the same time, the real transaction pump in socket process is already proceeded to OnStopRequest. So, when the suspend IPC message arrives in socket process, the state of transaction pump is STATE_IDLE.

Attachment #9156216 - Attachment description: Bug 1645346 - Clear transaction pump in OnStopRequest to avoid meaningless suspend and resume → Bug 1645346 - Clear transaction pump in OnStopRequest to avoid meaningless suspend and resume, r=dragana
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0108b63e8720 Clear transaction pump in OnStopRequest to avoid meaningless suspend and resume, r=dragana
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: