1645373 - Warp: support transpiling instanceof

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

After bug 1645353 we only have to add LoadInstanceOfObjectResult to support transpiling instanceof stubs.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1645373 - Part 1: Replace InstanceOfPolicy with BoxExceptPolicy. r=jandem!

InstanceOfPolicy is equivalent with BoxExceptPolicy, so let's use the
latter as the off the shelf type policy.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1645373 - Part 2: Change MInstanceOf to use MDefinition for the prototype. r=jandem!

Change MInstanceOf to use MDefinition for the prototype in preparation for
part 3. Lowering uses useRegisterOrConstant() to ensure we still bake in the
prototype for constant objects, which is the default in both Ion and Warp.

Drive-by change:
Remove bogus LInstanceOfV::lhs() and LInstanceOfCache::lhs() methods. The
left-hand side is a boxed operand, so it can't be accessed through getOperand.

Depends on D88573

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1645373 - Part 3: Transpile LoadInstanceOfObjectResult. r=jandem!

Transpile LoadInstanceOfObjectResult through the existing MInstanceOf op.
In contrast to the CacheIR implementation, MInstanceOf can also handle
proxy objects in the prototype chain via a VM call, whereas the CacheIR
implementation always bails out in that case.

Depends on D88574

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f21128ed923
Part 1: Replace InstanceOfPolicy with BoxExceptPolicy. r=jandem
https://hg.mozilla.org/integration/autoland/rev/fc32f8858aec
Part 2: Change MInstanceOf to use MDefinition for the prototype. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b077d656f564
Part 3: Transpile LoadInstanceOfObjectResult. r=jandem

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6f21128ed923
https://hg.mozilla.org/mozilla-central/rev/fc32f8858aec
https://hg.mozilla.org/mozilla-central/rev/b077d656f564