1645429 - Replace custom implementation of ReverseIterator by std::reverse_iterator

Status: RESOLVED FIXED

(Core :: MFBT, task)

Description

[Simon Giesecke [:sg] [he/him]]

mozilla::ReverseIterator does not appear to provide benefits over std::reverse_iterator, but it would require some fixes to be a proper STL-style iterator. Therefore, its implementation should be replaced by the use of std::reverse_iterator.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1645429 - Use std::reverse_iterator instead of mozilla::ReverseIterator where possible. r=froydnj

Depends on D79488

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1645429 - Replace custom implementation of mozilla::ReverseIterator by std::reverse_iterator. r=froydnj

Depends on D79489

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22a19cf66ef3
Use std::reverse_iterator instead of mozilla::ReverseIterator where possible. r=froydnj

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/22a19cf66ef3

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1645429 - Add tests for ReverseIterator and fix implementation of ReverseIterator::operator-. r=froydnj

Depends on D79488

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1645429 - Do not use ReverseIterator in nsTObserverArray::NonObservingRange. r=froydnj

Depends on D79957

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7734de6f12c6
Add tests for ReverseIterator and fix implementation of ReverseIterator::operator-. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/70be34453afb
Do not use ReverseIterator in nsTObserverArray::NonObservingRange. r=froydnj

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7734de6f12c6
https://hg.mozilla.org/mozilla-central/rev/70be34453afb