1645464 - Use a single set of ProfilerCategory definitions

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Ted Campbell [:tcampbell]]

Right now we duplicate profiler categories in js/public/ProfilingCategory.h and mozglue/baseprofiler/public/BaseProfilingCategory.h. I think we can reasonably share the definition without disturbing too much.

Proposal:

• Move the list to mozglue/baseprofiler/public/ProfilingCategoryList.h
• Add this to the moz.build EXPORTS list for both js/src and mozglue/baseprofiler.
• Rename the macro to MOZ_PROFILING_CATEGORY_LIST

This generates two copies in the build output, but there is only the single macro in it and header guards do the right thing.

Note that standalone SpiderMonkey bundles already include the baseprofiler source in their tarball.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1645464 - Use a shared ProfilingCategoryList.h r?gerald!

Replace the duplicate lists in mozglue/baseprofiler/public and js/public with
a shared list. Add this list to both moz.build files so it is published twice
which simplifies supporting different standalone configurations.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you so much for doing this (I wouldn't have known about the EXPORTS thing!)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c59c362decc
Use a shared ProfilingCategoryList.h r=gerald,froydnj

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7c59c362decc