1645465 - Log error messages when recording a telemetry event

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Emma Malysz]

We currently return RecordEventResult::Ok even if we don't record the event, which is misleading. See https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/core/TelemetryEvent.cpp#457-460.

We should either log a message here or add a unique value to the RecordEventResult enum. This will help telemetry debugging.

Comment 1

[Chris H-C :chutten]

We shouldn't log here as it would log every event recording in release builds if the event collection is prerelease-only. But a different return value is doable.

Comment 2

[Chris H-C :chutten]

Attachment: Bug 1645465 - Return non-Ok status when event cannot be recorded r?janerik!

We do not log in this case because this can happen normally if e.g. the event
is collected in prerelease channels only.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2af48ca6f91a
Return non-Ok status when event cannot be recorded r=janerik

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2af48ca6f91a

Comment 5

[Chris H-C :chutten]

Attachment: Bug 1645465 - uint variant values should convert over as uints, not ints r?froydnj!