Closed
Bug 1645465
Opened 4 years ago
Closed 4 years ago
Log error messages when recording a telemetry event
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: emmamalysz, Assigned: chutten)
Details
Attachments
(1 file, 1 obsolete file)
We currently return RecordEventResult::Ok even if we don't record the event, which is misleading. See https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/core/TelemetryEvent.cpp#457-460.
We should either log a message here or add a unique value to the RecordEventResult enum. This will help telemetry debugging.
|
Assignee | |
Comment 1•4 years ago
|
||
We shouldn't log here as it would log every event recording in release builds if the event collection is prerelease-only. But a different return value is doable.
Assignee: nobody → chutten
Severity: -- → S4
Status: NEW → ASSIGNED
Points: --- → 1
Priority: -- → P1
|
|
Assignee | |
Comment 2•4 years ago
|
||
We do not log in this case because this can happen normally if e.g. the event
is collected in prerelease channels only.
Pushed by chutten@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2af48ca6f91a Return non-Ok status when event cannot be recorded r=janerik
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
||
Updated•4 years ago
|
Attachment #9162302 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•