1645486 - Assertion failure: IsOnTRRThread(), at netwerk/dns/TRRService.cpp:926

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[Kershaw Chang [:kershaw]]

These two assertions are error prone.
Imagine the steps below.

1. When network_trr_fetch_off_main_thread is true, we dispatch a TRR request to TRR background thread.
2. network_trr_fetch_off_main_thread is changed to false.
3. The TRR request in step 1 is completed and TRRService::CompleteLookup is called on TRR background thread.
4. We hit the assertion.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1645486 - The TRR thread assertions should not depend on network_trr_fetch_off_main_thread pref

Comment 2

[Kershaw Chang [:kershaw]]

Review ping for https://phabricator.services.mozilla.com/D79537.
Thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab8a3004dd66
The TRR thread assertions should not depend on network_trr_fetch_off_main_thread pref r=valentin

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ab8a3004dd66