1645511 - Improve the provider manager's provider.updateBehavior calls

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Drew Willcoxon :adw]

The provider manager calls provider.updateBehavior here: https://searchfox.org/mozilla-central/rev/0e09b9191c02097034e46b193930f91c45b7885d/browser/components/urlbar/UrlbarProvidersManager.jsm#201

Marco and I noticed that the manager should check query.canceled after the await because the query may be quickly canceled while the manager is calling the providers.

Also, I'd like to not await each provider in turn but instead await a Promise.all so that the providers run concurrently. We made a similar change to the manager's isActive and startQuery calls when I implemented form history.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1645511 - Improve the provider manager's provider.updateBehavior calls.

I considered wrapping provider.tryMethod("updateBehavior", queryContext) in a
promise in case there are implementations that aren't async or don't return a
promise. But there's only one implementation of updateBehavior, it's async,
and we probably won't end up with any more implementations, so for simplicity I
didn't.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2db50c2da2f0d72127eb81f557d3b13f362e5e4

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b49ea5f44be0
Improve the provider manager's provider.updateBehavior calls. r=mak

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b49ea5f44be0

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b49ea5f44be0