Closed Bug 1645527 Opened 4 years ago Closed 4 years ago

Remove redundant PHttpChannel IPCs

Categories

(Core :: Networking: HTTP, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: CuveeHsu, Assigned: CuveeHsu)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

Please see bug 1639072 comment 1

AssociateApplicationCache and OverrideReferrerInfoDuringBeginConnect should be sent along with PHttpChannel::OnStartRequest to reduce potential race condition.

We're going to send OnStartRequest via PHttpBackgroundChannel, anything sending via PHttpChannel before OnStartRequest
would be a race.

https://phabricator.services.mozilla.com/D49773#inline-303635
This link implicates that OverrideReferrerInfoDuringBeginConnect is fine just before OnStartRequest. To reduce the
racy and number of IPCs, I move the referrer info overridden to HttpChannelParent::OnStartRequest.

Depends on D79579

Pushed by juhsu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3412b7655da
P1 AssociateApplicationCache should be sent in PHttpChannel::OnStartRequest, r=mayhemer,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/7bffad12d441
P2 move OverrideReferrerInfoDuringBeginConnect to PHttpChannel::OnStartRequest, r=baku,valentin,necko-reviewers,mayhemer
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.