Closed Bug 1645573 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 24137 - [FlexNG] Fix double reversal for wrap-reverse

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24137 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24137
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[FlexNG] Fix double reversal for wrap-reverse

We were double flipping some static positions for abspos flex children
with align-items: flex-{start,end}.

Included is an extensive test of static positions for abspos flex
children.

Fixed: 1090613
Bug: 845235
Change-Id: I1abd5d114c6740f3736d27aafdd4836b296d5d7b
Reviewed-on: https://chromium-review.googlesource.com/2244590
WPT-Export-Revision: 80f689f349f85f9f22a591cfe6b241a7c676aa85

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 432 subtests

Status Summary

Firefox

OK : 1
PASS: 384
FAIL: 48

Chrome

OK : 1
PASS: 336
FAIL: 96

Safari

OK : 1
PASS: 288
FAIL: 144

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-flexbox/position-absolute-013.html
.flexbox 396: FAIL
.flexbox 393: FAIL
.flexbox 390: FAIL
.flexbox 399: FAIL
.flexbox 111: FAIL
.flexbox 114: FAIL
.flexbox 117: FAIL
.flexbox 144: FAIL
.flexbox 141: FAIL
.flexbox 387: FAIL
.flexbox 99: FAIL
.flexbox 429: FAIL
.flexbox 420: FAIL
.flexbox 423: FAIL
.flexbox 426: FAIL
.flexbox 108: FAIL
.flexbox 102: FAIL
.flexbox 105: FAIL
.flexbox 411: FAIL
.flexbox 414: FAIL
.flexbox 417: FAIL
.flexbox 432: FAIL
.flexbox 135: FAIL
.flexbox 132: FAIL
.flexbox 138: FAIL
.flexbox 405: FAIL
.flexbox 402: FAIL
.flexbox 408: FAIL
.flexbox 120: FAIL
.flexbox 123: FAIL
.flexbox 126: FAIL
.flexbox 129: FAIL

New Tests That Don't Pass

/css/css-flexbox/position-absolute-013.html
.flexbox 396: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 393: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 390: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 399: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 276: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 270: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 273: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 279: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 111: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 114: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 117: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 249: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 246: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 243: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 144: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 141: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 387: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 99: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 429: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 420: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 423: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 426: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 108: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 102: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 105: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 258: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 255: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 252: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 411: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 414: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 417: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 282: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 285: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 432: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 288: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 135: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 132: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 138: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 261: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 267: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 264: FAIL (Chrome: PASS, Safari: FAIL)
.flexbox 405: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 402: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 408: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 120: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 123: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 126: FAIL (Chrome: PASS, Safari: PASS)
.flexbox 129: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/676cae6112c2 [wpt PR 24137] - [FlexNG] Fix double reversal for wrap-reverse, a=testonly https://hg.mozilla.org/integration/autoland/rev/ec228720a077 [wpt PR 24137] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/676cae6112c2
https://hg.mozilla.org/mozilla-central/rev/ec228720a077

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.