Closed Bug 1645586 Opened 4 months ago Closed 4 months ago

Picture-in-Picture should not activate with keyboard shortcut if set media.videocontrols.picture-in-picture.enabled = false

Categories

(Toolkit :: Video/Audio Controls, defect, P3)

78 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla79
Tracking Status
firefox79 --- verified

People

(Reporter: mail, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Open the config with about:config
Search for picture-in-picture
Set media.videocontrols.picture-in-picture.enabled to false
For good measure set media.videocontrols.picture-in-picture.video-toggle.enabled to false
Restart the browser
Visit a page with video e.g. https://www.youtube.com/watch?v=NH4DdXC0RFw and start playing the video
Use the keyboard shortcut Control + Shift + ]

Actual results:

A picture-in-picture video opened in the bottom right on my display

Expected results:

I would expect no picture-in-picture functionality to work if I've disabled it.
When using the keyboard shortcut Control + Shift + ] I would expect nothing to happen.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Video/Audio Controls
Product: Firefox → Toolkit
Assignee: nobody → gijskruitbosch+bugs
Severity: -- → S4
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
Regressed by: videopip
Blocks: videopip
No longer regressed by: videopip

I should note that my personal reason for not wanting that shortcut to trigger PiP (or anything else) is that I use it to change tabs (through Autokey). That shortcut is muscle memory from using a Mac for years.

I saw in a comment in Phabricator that you "could be convinced that the toggle pref shouldn't control the keyboard shortcut". Does that mean that there would be no way to disable the PiP shortcut? Or would there be a new pref to disable/enable it?

(In reply to tanc from comment #3)

I saw in a comment in Phabricator that you "could be convinced that the toggle pref shouldn't control the keyboard shortcut". Does that mean that there would be no way to disable the PiP shortcut? Or would there be a new pref to disable/enable it?

It would mean you could disable it by setting media.videocontrols.picture-in-picture.enabled to false, but not by setting media.videocontrols.picture-in-picture.video-toggle.enabled - the point is that, AFAICT, the latter is maybe just supposed to disable the visual, bright blue toggle, and not other UI entrypoints, as the context menu entry does not disappear if you just disable the video-toggle.enabled pref.

(In reply to :Gijs (he/him) from comment #4)

It would mean you could disable it by setting media.videocontrols.picture-in-picture.enabled to false, but not by setting media.videocontrols.picture-in-picture.video-toggle.enabled - the point is that, AFAICT, the latter is maybe just supposed to disable the visual, bright blue toggle, and not other UI entrypoints, as the context menu entry does not disappear if you just disable the video-toggle.enabled pref.

+1 makes sense

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f2f0cbc8b508
picture in picture shortcut should no-op if disabled, r=mconley
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Flags: qe-verify+

Confirmed issue with 79.0a1(2020-06-13).
Verified with 79.0b4 on Windows 10, macOS 10.15.5, Ubuntu 18.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.