Closed Bug 1645633 Opened 8 months ago Closed 7 months ago

Move listeners/observers in process-content.js to BrowserTabChild

Categories

(Toolkit :: General, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file, 1 obsolete file)

This file (process-content.js) contains three things:

  1. handles plugin crashing. A message from the parent causes gmpservice.RunPluginCrashCallbacks to be called.
  2. Older RPM initialization. Only newtab and talos tests currently use this. These are browser specific and initialize on document global created observer notifications. I think only need to apply to the top-level windows. Could use the existing BrowserTabChild actor which already listens to the window created event. 'xx-document-global-created' and DOMWindowCreated both fire one after another at https://searchfox.org/mozilla-central/rev/20ad814e4cc3d5eb3e33ccec6ed2b17255205aca/dom/base/nsGlobalWindowOuter.cpp#2591
  3. Something which stops favicons from loading when the window is destroyed. This could just wait for an actor to be destroyed.
Depends on: 1645544
Blocks: 1599535
Depends on: 1645541

Note that (1) above uses a message broadcaster which doesn't have an actor equivalent currently. The patches to be attached to this bug do only (2) and (3) so far.

Summary: Replace process-content.js with a JSProcessActor → Move listeners/observers in process-content.js to BrowserTabChild
Attachment #9156547 - Attachment is obsolete: true
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20cefae9a76f
setup RPM pages on the DOMWindowCreated event instead of using the 'xx-document-global-created' observer notification, r=mconley
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.