1645633 - Move listeners/observers in process-content.js to BrowserTabChild

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Neil Deakin]

This file (process-content.js) contains three things:

1. handles plugin crashing. A message from the parent causes gmpservice.RunPluginCrashCallbacks to be called.
2. Older RPM initialization. Only newtab and talos tests currently use this. These are browser specific and initialize on document global created observer notifications. I think only need to apply to the top-level windows. Could use the existing BrowserTabChild actor which already listens to the window created event. 'xx-document-global-created' and DOMWindowCreated both fire one after another at https://searchfox.org/mozilla-central/rev/20ad814e4cc3d5eb3e33ccec6ed2b17255205aca/dom/base/nsGlobalWindowOuter.cpp#2591
3. Something which stops favicons from loading when the window is destroyed. This could just wait for an actor to be destroyed.

Comment 1

[Neil Deakin]

Note that (1) above uses a message broadcaster which doesn't have an actor equivalent currently. The patches to be attached to this bug do only (2) and (3) so far.

Comment 2

[Neil Deakin]

Attachment: Bug 1645633, stop favicons from loading when the BrowserTabParent actor is destroyed instead of listening to a window destroyed message from the child, r=mak

Comment 3

[Neil Deakin]

Attachment: Bug 1645633, setup RPM pages on the DOMWindowCreated event instead of using the 'xx-document-global-created' observer notification, r=mconley

Depends on D79610

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20cefae9a76f
setup RPM pages on the DOMWindowCreated event instead of using the 'xx-document-global-created' observer notification, r=mconley

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/20cefae9a76f