1645672 - [Linux/EGL] Hardware decoding into dmabuf results in errors

Status: RESOLVED DUPLICATE of bug 1656436

(Core :: Audio/Video: Playback, defect, P5)

Description

[Francois Guerraz]

Attachment: MOZ_LOG="PlatformDecoderModule:5"

Trying to play YT videos with then new widget.wayland-dmabuf-video-textures.enabled pref set to true (default), results to stuttering, green frames and eventually errors.

[vp9 @ 0x7fa6aabda000] get_buffer() failed
[vp9 @ 0x7fa6aabda000] thread_get_buffer() failed

Config:
widget.wayland-dmabuf-vaapi.enabled=true
widget.wayland-dmabuf-video-textures.enabled=true
media.ffvpx.enabled

Comment 1

[Francois Guerraz]

Duplicate of bug 1645671 and bug 1645673

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Can you try to check if Bug 1629788 makes any difference here (i.e. test some former nightly)?
Thanks.

Comment 3

[Francois Guerraz]

This was with https://hg.mozilla.org/mozilla-unified/rev/e9818ea993d02a724e56da4dd9167fc1179de68f

Comment 4

[Francois Guerraz]

@stransky, I'm not sure what revision you want me to test but I had no issue with commit 1ed52478a3599f41ff05d2fc57eb5586aae622e5 (I don't use nightly because of bug 1430775, so I patch and build my own version, sigh)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1629788

Comment 6

[Francois Guerraz]

Why https://hg.mozilla.org/mozilla-central/rev/e9de35da7a75c9fd9ec6ca13d45030c55faf1148 ?

Now I can't use vaapi...

Comment 7

[Darkspirit]

VAAPI depends on dmabuf-video-textures - which is not finished yet (bug 1629788 comment 27). Without this patch you had to enable both prefs to use VAAPI. (Brief regressions are expected to happen on Nightly. Other patches still await review.)

Comment 8

[Martin Stránský [:stransky] (ni? me)]

This should be a dupe of Bug 1645671.

Comment 9

[Francois Guerraz]

I have tried D85152, which fixes Bug #1645671, but apart from the green frames, the other errors reported here are still not fixed:
Playing VP9 videos on youtube results in poor plaback quality, youtube swithing to lower quality, and eventually displaying an error message "An error occurred. Please try again later"

Comment 10

[Martin Stránský [:stransky] (ni? me)]

(In reply to Francois Guerraz from comment #9)

I have tried D85152, which fixes Bug #1645671, but apart from the green frames, the other errors reported here are still not fixed:
Playing VP9 videos on youtube results in poor plaback quality, youtube swithing to lower quality, and eventually displaying an error message "An error occurred. Please try again later"

Please attach MOZ_LOG="PlatformDecoderModule:5" log from your build where Bug 1645671 is fixed.
Thanks.

Comment 11

[Darkspirit]

I could retest bug 1643855 comment 9 if you could you trigger a try build of bug 1645671. Otherwise I'll wait for autoland.

Comment 12

[Francois Guerraz]

Attachment: Error even with D85152

D85152, fresh profile, with:
media.ffmpeg.vaapi-drm-display.enabled=true
media.ffmpeg.vaapi.enabled=true
media.ffvpx.enabled=false
security.sandbox.content.level=0

https://www.youtube.com/watch?v=LXb3EKWsInQ

Comment 13

[Darkspirit]

Attachment: vaapi_h264_1080p.txt

Indeed, bug 1645671 comment 23 fixed green frames, but YouTube decoding errors persist with (U)HD VP9 and HD H264.

MOZ_LOG="PlatformDecoderModule:5" MOZ_ENABLE_WAYLAND=1 mozregression --repo autoland --launch bacacb384008 --pref media.ffvpx.enabled:false media.ffmpeg.vaapi.enabled:true -a https://addons.mozilla.org/en-US/firefox/addon/enhanced-h264ify/ -a https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/ -a https://www.youtube.com/watch?v=Yds5jgqmYpE -P stdout

1:15.02 INFO: b'[h264 @ 0x7fc56bdc5800] nal_unit_type: 1(Coded slice of a non-IDR picture), nal_ref_idc: 2'
1:15.02 INFO: b'[h264 @ 0x7fc56bdc5800] get_buffer() failed'
1:15.02 INFO: b'[h264 @ 0x7fc56bdc5800] thread_get_buffer() failed'
1:15.02 INFO: b'[h264 @ 0x7fc56bdc5800] decode_slice_header error'
1:15.02 INFO: b'[h264 @ 0x7fc56bdc5800] no frame!'

Comment 15

[Darkspirit]

It's the same error I saw in bug 1643855 comment 9.

0:28.57 INFO: b'[h264 @ 0x7fdd5e5cc000] get_buffer() failed'
0:28.57 INFO: b'[h264 @ 0x7fdd5e5cc000] thread_get_buffer() failed'
0:28.57 INFO: b'[h264 @ 0x7fdd5e5cc000] decode_slice_header error'

Comment 16

[Darkspirit]

From a short test, software decoding with media.ffmpeg.dmabuf-textures.enabled seems to work fine. So much thanks as always!

comment 0 and comment 12 anyway have VAAPI enabled:
(Francois Guerraz from comment #0)

Config:
widget.wayland-dmabuf-vaapi.enabled=true
widget.wayland-dmabuf-video-textures.enabled=true
media.ffvpx.enabled

Comment 17

[Martin Stránský [:stransky] (ni? me)]

Please re-test when Bug 1656436 lands.
Thanks.

Comment 18

[Francois Guerraz]

Now this is working incredibly well!
Thank you ♥