Closed Bug 1645675 Opened 4 years ago Closed 4 years ago

WebrtcAudioConduit::SetDtmfPayloadType() always returns true

Categories

(Core :: WebRTC: Signaling, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: izbyshev, Assigned: dminor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Hello! I'm one of the developers of Svace static analyzer at ISPRAS, and I'd like to report defects found by Svace which I consider to be true positives. This is my first report of this kind here.

The return statement at https://hg.mozilla.org/mozilla-central/file/ede1c973aa85/media/webrtc/signaling/src/media-conduit/AudioConduit.cpp#l264 always returns true because mSendChannelProxy->SetSendTelephoneEventPayloadType returns a bool, which is then converted to int, so it's always either 0 or 1.

The same issue applies to WebrtcAudioConduit::InsertDTMFTone method below.

Note: since I'm going to report more defects if there is interest, please suggest ways to improve the workflow (e.g. marking reports with some tag, notifying specific people/teams, etc.).

Thanks for catching that!

For now, I'd suggest creating a meta bug called "Defects found with Svace static analysis" and then making bugs like this one block it. I'm not sure how familiar you are with Bugzilla, but here's an example of a meta bug just in case: https://bugzilla.mozilla.org/show_bug.cgi?id=screensharing. Note [meta] in the title and the meta keyword. From what I've seen, this is consistent with how people on our fuzzing team track issues found with their tooling, for instance.

Grouping related problems into a single bug like you've done here is helpful.

Assignee: nobody → dminor
Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3

Thank you for the pointers! I've created a meta-issue as you suggested.

Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/edff046107f3 Fix DTMF call return values in AudioConduit; r=ng
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: