1645678 - [Wayland] dmabuf-video-textures: Crash in [@ mozilla::widget::WaylandDisplayGet] MOZ_CRASH(There's too many wayland display conections!)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Darkspirit]

Gnome Wayland, Debian Testing
Tab crash. I clicked to play the "Ryan Levick - Rust at Microsoft" YouTube video on https://thenewstack.io/microsoft-rust-is-the-industrys-best-chance-at-safe-systems-programming/.

This is my main profile: VAAPI pref is disabled for testing. AV1 is disabled to use VP9 with media.ffvpx.enabled;false.

This bug is for crash report bp-4e653779-e439-4b69-84b7-2fb540200614.

MOZ_CRASH(There's too many wayland display conections!)

Top 10 frames of crashing thread:

0 libxul.so mozilla::widget::WaylandDisplayGet widget/gtk/nsWaylandDisplay.cpp:132
1 libxul.so WaylandDMABufSurfaceNV12::Create widget/gtk/WaylandDMABufSurface.cpp:843
2 libxul.so WaylandDMABufSurfaceNV12::CreateNV12Surface widget/gtk/WaylandDMABufSurface.cpp:726
3 libxul.so mozilla::FFmpegVideoDecoder<58>::CreateImageDMABuf dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp:750
4 libxul.so mozilla::FFmpegVideoDecoder<58>::DoDecode dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp:479
5 libxul.so mozilla::FFmpegDataDecoder<58>::DoDecode dom/media/platforms/ffmpeg/FFmpegDataDecoder.cpp:184
6 libxul.so mozilla::FFmpegDataDecoder<58>::ProcessDecode dom/media/platforms/ffmpeg/FFmpegDataDecoder.cpp:140
7 libxul.so mozilla::detail::ProxyRunnable<mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >, mozilla::MediaResult, true>, RefPtr<mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >, mozilla::MediaResult, true> >  xpcom/threads/MozPromise.h:1457
8 libxul.so mozilla::TaskQueue::Runner::Run xpcom/threads/TaskQueue.cpp:214
9 libxul.so nsThreadPool::Run xpcom/threads/nsThreadPool.cpp:299

Comment 1

[Darkspirit]

(I just assume that this came with bug 1629788. It doesn't seem to be reproducible.)

Comment 2

[Darkspirit]

bp-8442fcf8-3e3c-4921-bb69-2ca730200614 It happened when trying to play a video on Twitter. So it's rarely reproducible.

Comment 3

[Darkspirit]

15 of current 33 crashes are from me, mostly trying to play a video on Twitter. It's not that rare. Now I just open tweets with videos in a new tab and let them crash if they want to. After some hours I enabled Fission, but it didn't seem to be much different.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Let's disable dmabuf video textures for now - Bug 1645706.

Comment 5

[[e-mail]]

a decent chunk of the crashes should be me.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Yeah I also see this very very often on a lot of video-heavy twitter pages and such.

Comment 7

[John]

Not sure if it assists, but I am seeing this error extremely frequently when viewing videos on youtube and reddit. With many crash ids including: 0a99c204-8817-4297-b8de-7b3d80200722.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

This should be fixed now by Bug 1655026 - we don't use Wayland display to create the surfaces any more.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

I think we also should use DRM display on Wayland by default.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1645678 [Wayland] Use DRM display for VA-API decoding by default, r?jhorak

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c421c002286
[Wayland] Use DRM display for VA-API decoding by default, r=jhorak

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9c421c002286

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

We don't need that in beta, Thanks.