1645731 - Autocomplete panel exposed as an alert for accessibility

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[James Teh [:Jamie]]

STR (with NVDA):

1. Open the Dev Tools Console.
2. Type just "H" (capital h). Don't do anything else.
   • Expected: No lag.
   • Actual: NVDA reports "alert", then there's a ~7 second lag before you can do anything else with NVDA.

This occurs because the panel for the autocomplete popup is getting the alert role, so NVDA tries to walk its descendants to report the alert. There's explicit code to prevent this, but it's now acting on the wrong node (a div instead of the XUL panel).

This is a regression, but I don't know when it happened.

Impact: This makes the console pretty unusable for screen reader users.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1645731: Don't expose the autocomplete popup panel as an alert for accessibility.

There was already code to do this, but it was acting on a div instead of the XUL panel.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12ef06d0d76b
Don't expose the autocomplete popup panel as an alert for accessibility. r=nchevobbe

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/12ef06d0d76b