Closed Bug 1645742 Opened 8 months ago Closed 8 months ago

Firefox should retry getting a push subscription if it failed in the past

Categories

(Firefox :: Firefox Accounts, defect)

Product:
Firefox
Component:
Firefox Accounts
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: markh, Assigned: markh)

Details

Attachments

(1 file)

Bug 1645742 - ensure FxA has a push subscription as well as whether it has expired. r?rfkelly
47 bytes, text/x-phabricator-request
Details | Review

If we fail to get a push subscription as part of the signin/signup flow, we will retry a number of times (depending on verified state etc), but if we always fail but the account becomes fully verified, we appear to never retry.

This is probably as simple as checking if we have any subscription rather than just for expiry, in https://searchfox.org/mozilla-central/source/services/fxaccounts/FxAccountsDevice.jsm#226

Assignee: nobody → markh
Status: NEW → ASSIGNED
Pushed by mhammond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f8bcb1a6ef8
ensure FxA has a push subscription as well as whether it has expired. r=rfkelly

https://hg.mozilla.org/mozilla-central/rev/1f8bcb1a6ef8

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
You need to log in before you can comment on or make changes to this bug.