1645766 - build failure in dom/media/AsyncLogger.h

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect)

Description

[Dan Horák]

Looks like the changes from bug 1626918 broke build on ppc64le, because the inttypes.h header is not included before using PRIu64.

/usr/bin/g++ -std=gnu++17 -o Unified_cpp_dom_media11.o -c  -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu/dist/stl_wrappers -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu/dist/system_wrappers -include /home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DHAVE_UINT64_T -DWEBRTC_POSIX -DWEBRTC_BUILD_LIBEVENT -DWEBRTC_LINUX -DMOZILLA_INTERNAL_API -DTRACING -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu/dom/media -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/caps -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/docshell/base -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/base -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/layout/generic -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/layout/xul -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/media/libyuv/libyuv/include -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/netwerk/base -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/toolkit/content/tests/browser -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/media/webrtc/signaling/src/common -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/media/webrtc/trunk -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/media/webrtc/trunk/webrtc -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu/ipc/ipdl/_ipdlheaders -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/ipc/chromium/src -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/ipc/glue -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu/dist/include -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu/dist/include/nspr -I/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu/mozilla-config.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wno-error=deprecated-copy -Wformat -Wformat-overflow=2 -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O2 -fno-omit-frame-pointer -funwind-tables -Wno-error=shadow -Wno-error=attributes -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_dom_media11.o.pp   Unified_cpp_dom_media11.cpp
In file included from /home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/Tracing.h:14,
                 from /home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/Tracing.cpp:7,
                 from Unified_cpp_dom_media11.cpp:2:
/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/AsyncLogger.h: In member function ‘void mozilla::AsyncLogger::Log(const char*, const char*, const char*, mozilla::AsyncLogger::TracingPhase)’:
/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/AsyncLogger.h:106:24: error: expected ‘)’ before ‘PRIu64’
  106 |             "\"ts\": %" PRIu64
      |                        ^~~~~~~
      |                        )
/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/AsyncLogger.h:104:18: note: to match this ‘(’
  104 |         LogMozLog(
      |                  ^
/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/AsyncLogger.h:106:22: warning: spurious trailing ‘%’ in format [-Wformat=]
  106 |             "\"ts\": %" PRIu64
      |                      ^
/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/AsyncLogger.h:105:13: warning: too many arguments for format [-Wformat-extra-args]
  105 |             "{\"name\": \"%s\", \"cat\": \"%s\", \"ph\": \"%c\","
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  106 |             "\"ts\": %" PRIu64
      |             ~~~~~~~~~~~
/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/AsyncLogger.h: In member function ‘void mozilla::AsyncLogger::LogDuration(const char*, const char*, uint64_t, uint64_t, uint64_t)’:
/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/AsyncLogger.h:135:24: error: expected ‘)’ before ‘PRIu64’
  135 |             "\"ts\": %" PRIu64 ", \"dur\": %" PRIu64
      |                        ^~~~~~~
      |                        )
/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/AsyncLogger.h:133:18: note: to match this ‘(’
  133 |         LogMozLog(
      |                  ^
/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/AsyncLogger.h:135:22: warning: spurious trailing ‘%’ in format [-Wformat=]
  135 |             "\"ts\": %" PRIu64 ", \"dur\": %" PRIu64
      |                      ^
/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/dom/media/AsyncLogger.h:134:13: warning: too many arguments for format [-Wformat-extra-args]
  134 |             "{\"name\": \"%s\", \"cat\": \"%s\", \"ph\": \"X\","
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  135 |             "\"ts\": %" PRIu64 ", \"dur\": %" PRIu64
      |             ~~~~~~~~~~~
gmake[4]: *** [/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/config/rules.mk:748: Unified_cpp_dom_media11.o] Error 1
gmake[4]: Leaving directory '/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu/dom/media'
gmake[3]: *** [/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/config/recurse.mk:74: dom/media/target-objects] Error 2
gmake[3]: Leaving directory '/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu'
gmake[2]: *** [/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/config/recurse.mk:34: compile] Error 2
gmake[2]: Leaving directory '/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu'
gmake[1]: *** [/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/config/rules.mk:390: default] Error 2
gmake[1]: Leaving directory '/home/jenkins/workspace/Firefox-default/label/ppc64le/firefox/obj-powerpc64le-unknown-linux-gnu'
gmake: *** [client.mk:125: build] Error 2

Possible fix is

diff --git a/dom/media/AsyncLogger.h b/dom/media/AsyncLogger.h
index c558843b0e3..041511d2e2e 100644
--- a/dom/media/AsyncLogger.h
+++ b/dom/media/AsyncLogger.h
@@ -9,6 +9,7 @@
 
 #include <atomic>
 #include <thread>
+#include <cinttypes>
 #include "mozilla/ArrayUtils.h"
 #include "mozilla/Attributes.h"
 #include "mozilla/Logging.h"

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1645766 - Fix build failure in AsyncLogger.h on ppc64le. r?achronop

Thanks to Dan Horák <[e-mail]> for the report and fix suggestion.

Comment 2

[Paul Adenot (:padenot)]

Thanks Dan, hopefully this fixes it, if not let me know and I'll investigate harder.

Comment 3

[Dan Horák]

yes, trunk builds OK with the fix

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a71fbe527e8
Fix build failure in AsyncLogger.h on ppc64le. r=achronop

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9a71fbe527e8