1645768 - Please add 'See Also' support for GitLab

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Bug Creation/Editing, enhancement)

Description

[Michał Górny]

There is a growing number of projects using GitLab for their contributions. However, it seems that even with MoreBugUrl extension GitLab merge requests URL are not accepted in 'See also'. Could it be extended for that, please?

GitLab issue and merge request URLs follow the following patterns, respectively:

https://<domain>[/<relative_url>]/<group>/<project>/-/issues/<number>
https://<domain>[/<relative_url>]/<group>/<project>/-/merge_requests/<number>

The 'issues' part seems to be handled already by the support for some other backend, however 'merge_requests' are not. I suspect it would be reasonable to match them via path ending with '/-/merge_requests/[0-9]+'.

Examples:

https://invent.kde.org/multimedia/kdenlive/-/issues/724
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/82

Disclaimer: I've tested it only on 5.0.6 but grepped git master for 'merge_requests'.

Comment 1

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 2

[David Lawrence [:dkl]]

Merged to master.

Comment 3

[David Lawrence [:dkl]]

This change is live now.

Comment 4

[Michał Górny]

I'm sorry but I'm confused. Does that mean that this feature will only be available on BMO but not in 'regular' Bugzilla code to be consumed downstream?

Comment 5

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

(In reply to Michał Górny from comment #4)

I'm sorry but I'm confused. Does that mean that this feature will only be available on BMO but not in 'regular' Bugzilla code to be consumed downstream?

Yes, upstream would need to cherry pick the patch from our repository.