1645777 - Crash in [@ mozilla::PermissionManager::GetKeyForPrincipal]

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-550e15ac-c709-4c8f-af9e-97ac00200614.

Top 10 frames of crashing thread:

0 XUL mozilla::PermissionManager::GetKeyForPrincipal extensions/permissions/PermissionManager.cpp:3069
1 XUL mozilla::ContentBlocking::UpdateAllowAccessOnParentProcess toolkit/components/antitracking/ContentBlocking.cpp:791
2 XUL mozilla::ContentBlocking::SaveAccessForOriginOnParentProcess toolkit/components/antitracking/ContentBlocking.cpp:618
3 XUL mozilla::ContentBlocking::CompleteAllowAccessFor const toolkit/components/antitracking/ContentBlocking.cpp:509
4 XUL mozilla::ContentBlocking::CompleteAllowAccessFor toolkit/components/antitracking/ContentBlocking.cpp:564
5 XUL mozilla::dom::ContentParent::RecvCompleteAllowAccessFor dom/ipc/ContentParent.cpp:6004
6 XUL mozilla::dom::PContentParent::OnMessageReceived ipc/ipdl/PContentParent.cpp:11218
7 XUL mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2166
8 XUL mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1969
9 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1238

There is 1 crash in nightly 79 with buildid 20200613214137. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1643115.

[1] https://hg.mozilla.org/mozilla-central/rev?node=c9b9111c017f

Comment 1

[[:philipp]]

[Tracking Requested - why for this release]:
judging by affected installations this crash is #7 on list of top browser crashers list in 79.0b and accounting for 0.7% of all crashes.

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1645777 - Add nullptr check after calling AntiTrackingUtils::GetPrincipal r=timhuang

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d69131a21fee
Add nullptr check after calling AntiTrackingUtils::GetPrincipal r=timhuang

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d69131a21fee

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dimi, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Dimi Lee [:dimi]]

Comment on attachment 9161036 [details]
Bug 1645777 - Add nullptr check after calling AntiTrackingUtils::GetPrincipal r=timhuang

Beta/Release Uplift Approval Request

• User impact if declined: May crash while visiting sites that have trackers.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): only a nullptr check
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9161036 [details]
Bug 1645777 - Add nullptr check after calling AntiTrackingUtils::GetPrincipal r=timhuang

Approved for 79.0b5.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c92c1138c312