Closed Bug 1645794 Opened 3 months ago Closed 3 months ago

dom/html/reftests/autofocus/textarea-* testcases are unreliable due to a layout sizing bug

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(1 file)

See bug 1645773 for standalone testcase: the use of background-color in the :focus style for the textarea tests here makes them unreliable (dependent on exact timing of reflows etc).

To paper over this issue for the sake of the autofocus tests here, I propose replacing the use of background-color in the styles with a different property that will not affect the sizing. Obviously, the underlying layout issue remains open, and should be fixed, but these tests can be made independent of it.

See Layout bug 1645773 for details. This patch works around the unreliability
by styling the text color instead of background, which has no effect on the
element sizing.

Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #9156699 - Attachment description: Bug 1645794 - Don't use background-color in textarea's :focus styling, because it causes unreliable sizing. r=emilio → Bug 1645794 - Set -moz-appearance:none on textareas, to avoid unreliable sizing when setting/removing background. r=emilio
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90b56445e97a
Set -moz-appearance:none on textareas, to avoid unreliable sizing when setting/removing background. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.