1645842 - Reverse-elfhack code in android xpcshell harness is no longer used

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, enhancement, P1)

Description

[Geoff Brown [:gbrown] (pto Jul 1-19)]

Bug 1389805 added xpcshell harness support for reverse-elfhack, but I find it is no longer being used, neither in CI nor with local builds; this condition is never positive, with current builds:
https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/testing/xpcshell/remotexpcshelltests.py#497

Let's remove that code to avoid the file access overhead, and also incidentally, avoid a py3 incompatibility.

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Geoff Brown [:gbrown] from comment #0)

Bug 1389805 added xpcshell harness support for reverse-elfhack, but I find it is no longer being used, neither in CI nor with local builds; this condition is never positive, with current builds:
https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/testing/xpcshell/remotexpcshelltests.py#497

Let's remove that code to avoid the file access overhead, and also incidentally, avoid a py3 incompatibility.

gbrown: I happen to know that the perf team is having a hard time symbolicating GeckoView on ARMv7: see this issue. Is it possible that this reverse-elfhack step is required? (I have never heard of this step until now so I know nothing.)

acreskey: this might be relevant to your interests.

Comment 2

[Geoff Brown [:gbrown] (pto Jul 1-19)]

I don't think so. We only ever used it for xpcshell.

Comment 3

[Geoff Brown [:gbrown] (pto Jul 1-19)]

Attachment: Bug 1645842 - Remove reverse-elfhack support from android xpcshell harness; r=

Remove some dead code from remote xpcshell harness.

Comment 4

[Geoff Brown [:gbrown] (pto Jul 1-19)]

Also verified crash reports after this change:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2620cc9e3da64e8db33ff976f7000732ea7e67c3

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b706339211b
Remove reverse-elfhack support from android xpcshell harness; r=bc

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9b706339211b