Closed Bug 1645842 Opened 8 months ago Closed 8 months ago

Reverse-elfhack code in android xpcshell harness is no longer used

Categories

(Testing :: XPCShell Harness, enhancement, P1)

enhancement

Tracking

(firefox79 fixed)

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

Bug 1389805 added xpcshell harness support for reverse-elfhack, but I find it is no longer being used, neither in CI nor with local builds; this condition is never positive, with current builds:
https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/testing/xpcshell/remotexpcshelltests.py#497

Let's remove that code to avoid the file access overhead, and also incidentally, avoid a py3 incompatibility.

(In reply to Geoff Brown [:gbrown] from comment #0)

Bug 1389805 added xpcshell harness support for reverse-elfhack, but I find it is no longer being used, neither in CI nor with local builds; this condition is never positive, with current builds:
https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/testing/xpcshell/remotexpcshelltests.py#497

Let's remove that code to avoid the file access overhead, and also incidentally, avoid a py3 incompatibility.

gbrown: I happen to know that the perf team is having a hard time symbolicating GeckoView on ARMv7: see this issue. Is it possible that this reverse-elfhack step is required? (I have never heard of this step until now so I know nothing.)

acreskey: this might be relevant to your interests.

Flags: needinfo?(gbrown)
Flags: needinfo?(acreskey)

I don't think so. We only ever used it for xpcshell.

Flags: needinfo?(gbrown)

Remove some dead code from remote xpcshell harness.

Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b706339211b
Remove reverse-elfhack support from android xpcshell harness; r=bc
Blocks: 1645888
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Flags: needinfo?(acreskey)
You need to log in before you can comment on or make changes to this bug.