Closed Bug 1645980 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 24163 - [LayoutNG] Blocks with no same-flow breaks have perfect break appeal.

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24163 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24163
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

[LayoutNG] Blocks with no same-flow breaks have perfect break appeal.

We used to only update the appeal of breaking inside a box when
inserting an in-flow break, either before/inside an in-flow child, or
inside the box itself (if its non-auto remaining block-size was too
large to fit).

What was missing was when the box itself could fit, and it only had
parallel flow breaks.

Without this fix, if a float broke inside a block, and the block itself
didn't need a break for its own sake, we'd consider the break inside to
be a last-resort break (so that we'd try our best to break earlier).

Bug: 829028
Change-Id: I5cd5f05ea319a75186c7510bf40dd54b104160b0
Reviewed-on: https://chromium-review.googlesource.com/2245911
WPT-Export-Revision: 8e2cf0e09311e457fb011521bf10960451e0b212

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/971c73c56b5a
[wpt PR 24163] - [LayoutNG] Blocks with no same-flow breaks have perfect break appeal., a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.