1645980 - [wpt-sync] Sync PR 24163 - [LayoutNG] Blocks with no same-flow breaks have perfect break appeal.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24163 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24163
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

[LayoutNG] Blocks with no same-flow breaks have perfect break appeal.

We used to only update the appeal of breaking inside a box when
inserting an in-flow break, either before/inside an in-flow child, or
inside the box itself (if its non-auto remaining block-size was too
large to fit).

What was missing was when the box itself could fit, and it only had
parallel flow breaks.

Without this fix, if a float broke inside a block, and the block itself
didn't need a break for its own sake, we'd consider the break inside to
be a last-resort break (so that we'd try our best to break earlier).

Bug: 829028
Change-Id: I5cd5f05ea319a75186c7510bf40dd54b104160b0
Reviewed-on: https://chromium-review.googlesource.com/2245911
WPT-Export-Revision: 8e2cf0e09311e457fb011521bf10960451e0b212

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b488f4a5822576516c02ef07d8603e317eca9d52

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/971c73c56b5a
[wpt PR 24163] - [LayoutNG] Blocks with no same-flow breaks have perfect break appeal., a=testonly

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/971c73c56b5a