1646010 - [Translate] Refactor Editor code to use React hooks

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P3)

Description

[Adrian Gaudebert]

In order to simplify adding new editor implementations to Pontoon — for example to run experimentation around Fluent support — we want to refactor the editor code to:

• make it simpler to maintain
• make it easier to implement a new editor
• make it easier to integrate a new editor implementation

This involves rewriting most components in the Editor hierarchy to use hooks, as well as their associated unit tests. All features should work exactly the same as before.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1648

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1727

Comment 3

[Matjaz Horvat [:mathjazz]]

I've deployed the editor to prod and found a bug while doing my regular translate and review session.

A blank editor appeared. I found two ways to reproduce it.

In the meantime, I've reverted the patch from prod, but it remains deployed to stage.

Steps to reproduce 1/:

1. Open any string.
2. Click on the same string in the string list again.
3. Expected result: String in the editor remains unchanged.
4. Actual result: Editor becomes empty (textarea gets empty in case of generic editor, dark background appears in case of rich editor).

Steps to reproduce 2/:

1. Open an unreviewed string in the rich editor, that is followed by a simple string.
2. Approve it.
3. Expected result: next string opens in the generic editor.
4. Actual result: dark background appears.

Comment 4

[Matjaz Horvat [:mathjazz]]

Found another bug:

In generic editor, COPY button copies FTL strings as source ("key = value" instead of just "value").

The button behaves as expected in the Rich and Source editors.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1757