Closed Bug 1646019 Opened 8 months ago Closed 8 months ago

PreloadHashKey for as="style" shouldn't use the whole referrer info as part of the key.

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file, 1 obsolete file)

We probably should remove the referrer policy check altogether in bug 1642591, but the preload code still uses the whole referrer as the key, which the css loader stopped doing in bug 1599160.

So this should be an uncontroversial simplification.

We probably should remove the referrer policy check altogether in
bug 1642591, but the preload code still uses the whole referrer as the
key for css, which the css loader stopped doing in bug 1599160.

So this should be an uncontroversial simplification.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/071ebe8caaf1
Make PreloadHashKey don't check referrer for equality for style. r=mayhemer

This test fails already on master if you change this line:

https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/image/test/unit/test_private_channel.js#93

by:

Ci.nsIReferrerInfo.EMPTY

Because the previous part of the test populates the image cache. The
test wants to check that the channel for the image load is properly
flagged as private and thus that the http cache is partitioned
appropriately, thus clearing the image caches seems sane.

While at it, also fix it so that we send a valid image instead of base64
text, though that change is not technically needed so feel free to ask
me to remove it.

Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79

Comment on attachment 9157010 [details]
Bug 1646019 - Fix image/test/unit/test_private_channel.js. r=tnikkel

Revision D79848 was moved to bug 1642591. Setting attachment 9157010 [details] to obsolete.

Attachment #9157010 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.