1646029 - Protections ETP on/off tooltip overwrites builtin description element

Status: NEW

(Firefox :: Site Identity, defect, P3)

Description

[:Gijs (he/him)]

        <tooltip id="protections-popup-not-blocking-why-etp-on-tooltip" data-l10n-id="protections-panel-not-blocking-why-etp-on-tooltip"></tooltip>
        <tooltip id="protections-popup-not-blocking-why-etp-off-tooltip" data-l10n-id="protections-panel-not-blocking-why-etp-off-tooltip"></tooltip>

both use fluent to set their textContent, but the normal way of setting the contents of a tooltip node is to set their label attribute, which gets reflected into the builtin description element that gets inserted by the C++ XUL tooltip implementation.

Comment 1

[:Gijs (he/him)]

I found this from the warnings I'm adding in bug 1645246.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:nhnt11, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Thanks for reporting this. Could you help me understand the exact user-facing issue here (if there is one)? Does this have any a11y impact?

Comment 4

[:Gijs (he/him)]

(In reply to Nihanth Subramanya [:nhnt11] from comment #3)

Thanks for reporting this. Could you help me understand the exact user-facing issue here (if there is one)? Does this have any a11y impact?

I don't know whether there's any user impact. It's just odd. I adding fluent warnings for when localization passes clobber child elements in the localized element (which is designed to catch more obviously problematic cases), and that turned up this bug.

It's trivial to fix, just make the fluent identifiers set the label attribute and use a fluent-to-fluent migration to migrate existing strings.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Thanks!