Port certError and netError pages changes to SeaMonkey
Categories
(SeaMonkey :: Security, task)
Tracking
(seamonkey2.53 unaffected, seamonkey2.57esr? affected)
| Tracking | Status | |
|---|---|---|
| seamonkey2.53 | --- | unaffected |
| seamonkey2.57esr | ? | affected |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.57)
Attachments
(3 files, 1 obsolete file)
|
20.88 KB,
patch
|
frg
:
review+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
3.51 KB,
patch
|
frg
:
review+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
2.24 KB,
patch
|
frg
:
review+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Port a number of bugs relating to certError / netError pages to SeaMonkey:
- Bug 1415279 - Move error strings for certError and netError pages to frontend
- Bug 1448787 - separate error for self-signed certs
- Bug 1450967 - mitm detection v0.0.1
[Approval Request Comment]
Regression caused by (bug #): 1415279
User impact if declined: Missing information from certError / netError pages
Testing completed (on m-c, etc.): 2.57
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Changes since last version:
- Fixed missing details on netError pages
- Fixed formatting of netErrpr pages
- Inlined single use functions / removed unused functions in certError.js
[Approval Request Comment]
Regression caused by (bug #): 1448787
User impact if declined: None
Testing completed (on m-c, etc.): 2.57
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9157033 [details] [diff] [review]
Move strings to frontend v1.1
Works fine r/a+
NIT:
BrowserUtils is not imported in /suite/browser/content.js. Progably gets it from somewhere else or I didn't hit this codepath during testing. Please import.
|
|
||
Comment 6•5 years ago
|
||
Comment on attachment 9157066 [details] [diff] [review]
Separate error for self-signed
LGTM
|
|
||
Comment 7•5 years ago
|
||
Comment on attachment 9157099 [details] [diff] [review]
Add MitM message
LGTM
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/5f5c0ebf2c86
Port |Bug 1415279 - Move error strings for certError and netError pages to frontend| to SeaMonkey. r=frg
https://hg.mozilla.org/comm-central/rev/a6f2034ac2f5
Port |Bug 1448787 - separate error for self-signed certs| to SeaMonkey. r=frg
https://hg.mozilla.org/comm-central/rev/6a6e690c5b88
Port |Bug 1450967 - mitm detection v0.0.1| to SeaMonkey. r=frg
|
|
||
Updated•5 years ago
|
Description
•