1646087 - AttributeError: 'TestSetUpSkipped' object has no attribute 'marionette'

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Running all of Marionette unit tests I noticed the following error:

AttributeError: 'TestSetUpSkipped' object has no attribute 'marionette'

  File "/Users/henrik/code/gecko/testing/marionette/mach_commands.py", line 104, in marionette_test
    return run_marionette(tests, topsrcdir=self.topsrcdir, **kwargs)
  File "/Users/henrik/code/gecko/testing/marionette/mach_commands.py", line 61, in run_marionette
    failed = MarionetteHarness(MarionetteTestRunner, args=vars(args)).run()
  File "/Users/henrik/code/gecko/testing/marionette/harness/marionette_harness/runtests.py", line 71, in run
    runner.run_tests(tests)
  File "/Users/henrik/code/gecko/testing/marionette/harness/marionette_harness/runner/base.py", line 894, in run_tests
    self.run_test_sets()
  File "/Users/henrik/code/gecko/testing/marionette/harness/marionette_harness/runner/base.py", line 1096, in run_test_sets
    self.run_test_set(self.tests)
  File "/Users/henrik/code/gecko/testing/marionette/harness/marionette_harness/runner/base.py", line 1074, in run_test_set
    self.run_test(test['filepath'], test['expected'])
  File "/Users/henrik/code/gecko/testing/marionette/harness/marionette_harness/runner/base.py", line 1044, in run_test
    results = runner.run(suite)
  File "/Users/henrik/code/gecko/testing/marionette/harness/marionette_harness/runner/base.py", line 243, in run
    result = super(MarionetteTextTestRunner, self).run(test)
  File "/Users/henrik/code/gecko/testing/mozbase/moztest/moztest/adapters/unit.py", line 214, in run
    test(result)
  File "/usr/local/Cellar/python@2/2.7.17/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/suite.py", line 70, in __call__
    return self.run(*args, **kwds)
  File "/usr/local/Cellar/python@2/2.7.17/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/suite.py", line 108, in run
    test(result)
  File "/usr/local/Cellar/python@2/2.7.17/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 393, in __call__
    return self.run(*args, **kwds)
  File "/Users/henrik/code/gecko/testing/marionette/harness/marionette_harness/marionette_test/testcases.py", line 237, in run
    self.cleanTest()
  File "/Users/henrik/code/gecko/testing/marionette/harness/marionette_harness/marionette_test/testcases.py", line 297, in cleanTest
    self._delete_session()
  File "/Users/henrik/code/gecko/testing/marionette/harness/marionette_harness/marionette_test/testcases.py", line 302, in _delete_session
    if self.marionette.session is not None:
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-C to quit

The affected test here is testing/marionette/harness/marionette_harness/tests/unit/test_skip_setup.py.

Given that this test file is not part of the manifest it's not getting run at all in CI.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This can be fixed by calling MarionetteTestCase.setUp(self) as the very first thing in setUp().

https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/testing/marionette/harness/marionette_harness/tests/unit/test_skip_setup.py#19

Further an entry for the test file needs to be added here:

https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/testing/marionette/harness/marionette_harness/tests/unit/unit-tests.ini#12

Comment 2

[Bruno Bartolomasi]

Attachment: Bug 1646087 - [marionette] Fix test_skip_setup.py and run it as part of the unit tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/757a8a771dc1
[marionette] Fix test_skip_setup.py and run it as part of the unit tests. r=marionette-reviewers,whimboo

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/757a8a771dc1

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Bruno, thanks a lot for your contribution!