1646093 - Modify printing telemetry to add a PDF-catch-all for unknown printer names containing 'PDF'

Status: RESOLVED FIXED

(Toolkit :: Printing, task, P1)

Description

[Jonathan Watt [:jwatt]]

In bug 1600623 we added some telemetry that in part attempts to collect information on whether users are printing to PDF or a printer. The number of prints-to-PDF that we're seeing come in are a lot lower than expected. To sanity check that this isn't because we're missing widely used "PDF" printer names we'd like to add a catch-all for unknown printers with "PDF" in their name.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1646093. Modify printing telemetry to add a PDF-catch-all for possible unknown PDF printers. r=bobowen

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Data review form

Comment 3

[Chris H-C :chutten]

Comment on attachment 9157018 [details]
Data review form

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :jwatt is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c456cb4b4047
Modify printing telemetry to add a PDF-catch-all for possible unknown PDF printers. r=bobowen

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on nsDeviceContextSpecWin.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/83eb57b7cec1d2a084334625f813549b06434826
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306512829&repo=autoland&lineNumber=29713

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3703059ed8f0
Modify printing telemetry to add a PDF-catch-all for possible unknown PDF printers. r=bobowen

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3703059ed8f0

Comment 8

[Jonathan Watt [:jwatt]]

Comment on attachment 9157017 [details]
Bug 1646093. Modify printing telemetry to add a PDF-catch-all for possible unknown PDF printers. r=bobowen

Beta/Release Uplift Approval Request

• User impact if declined: This is a tweak to the telemetry added in bug 1600623. We have suspiciously low 'print-to-pdf' counts on Windows relative to macOS. This adds another catch-all bucket to allow us to sanity check our numbers to remove the uncertainty over whether our numbers are useful or not.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very simple telemetry change to add another key to an existing keyed scalar probe.
• String changes made/needed: none

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9157017 [details]
Bug 1646093. Modify printing telemetry to add a PDF-catch-all for possible unknown PDF printers. r=bobowen

approved for 78.0b9

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b0b8663161d5