1646128 - Rename SearchService.getDefaultEngines to SearchService.getAppProvidedEngines

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

getDefaultEngines can be confusing because you're not sure if that is referring to the user's selected/preferred engines, or to the list of engines that are provided by Firefox automatically.

I think we should rename it to make it clearer and avoid that confusion. It is a little longer however getAppProvidedEngines would seem to fit with SearchEngine.isAppProvided

Comment 1

[Amy Churchwell [:amy]]

Attachment: Bug 1646128 - Renamed SearchService.getDefaultEngines to SearchService.getAppProvidedEngines. r?harry

Comment 2

[Harry Twyford]

https://treeherder.mozilla.org/jobs?repo=try&revision=f909f7ef5228c92e5792261ba2a3ed2176e437fc

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5111a57ad25
Renamed SearchService.getDefaultEngines to SearchService.getAppProvidedEngines. r=harry

Comment 4

[Atila Butkovits]

Backed out for failure on browser_engines.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9db38d8a088ceed2559a0f45b733e97b075a787e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=GQRhE8nVTeSAZv2eBMHfJw.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Cmochitests%2Ctest-linux1804-64-asan%2Fopt-mochitest-browser-chrome-e10s%2Cbc5&revision=d5111a57ad25315ec07d0612cf95257b3a622a6d

Failure log: https://treeherder.mozilla.org/logviewer?job_id=324836936&repo=autoland&lineNumber=3126

Comment 5

[Harry Twyford]

Looks like mach try auto missed browser_engines.js. Here's a new try run targeting all mochitests and xpcshell tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3f9d0be9479aa277eddd3795ab26aa20f9b64a2

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/897f30ea5f53
Renamed SearchService.getDefaultEngines to SearchService.getAppProvidedEngines. r=harry

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/897f30ea5f53

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf2fb1113dc7
rename SearchService.getDefaultEngines to SearchService.getAppProvidedEngines for Thunderbird. rs=bustage-fix