Closed Bug 1646128 Opened 1 year ago Closed 9 months ago

Rename SearchService.getDefaultEngines to SearchService.getAppProvidedEngines

Categories

(Firefox :: Search, task, P3)

task
Points:
1

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: standard8, Assigned: amy)

Details

Attachments

(1 file)

getDefaultEngines can be confusing because you're not sure if that is referring to the user's selected/preferred engines, or to the list of engines that are provided by Firefox automatically.

I think we should rename it to make it clearer and avoid that confusion. It is a little longer however getAppProvidedEngines would seem to fit with SearchEngine.isAppProvided

Severity: -- → N/A
Priority: -- → P3
Points: --- → 1
Assignee: nobody → achurchwell
Status: NEW → ASSIGNED
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5111a57ad25
Renamed SearchService.getDefaultEngines to SearchService.getAppProvidedEngines. r=harry

Looks like mach try auto missed browser_engines.js. Here's a new try run targeting all mochitests and xpcshell tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3f9d0be9479aa277eddd3795ab26aa20f9b64a2

Flags: needinfo?(achurchwell)
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/897f30ea5f53
Renamed SearchService.getDefaultEngines to SearchService.getAppProvidedEngines. r=harry
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/bf2fb1113dc7
rename SearchService.getDefaultEngines to SearchService.getAppProvidedEngines for Thunderbird. rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.