1646155 - Make artifact builds much less verbose by default

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P3)

Description

[Nick Alexander :nalexander [he/him]]

mach build with --enable-artifact-builds prints a lot of information. Most of it is constant and not actionable in any circumstance. Let's make this much less verbose.

In error cases, mach artifact install -v can be used to debug problems.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1646155: Changes most artifact-build logs from INFO to DEBUG r?rstewart

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

The artifact output situation has improved significantly, but there's still a lot of noise from node.py during file-generation that looks some thing like:

...
 0:04.70 Executing "/home/mitch/.mozbuild/node/bin/node /home/mitch/dev/firefox/devtools/client/shared/build/build.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/breakpoint/astBreakpointLocation.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/breakpoint/breakpointPositions.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/breakpoint/index.js /home/mitch/dev/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/utils/breakpoint"
 0:04.81 Executing "/home/mitch/.mozbuild/node/bin/node /home/mitch/dev/firefox/devtools/client/shared/build/build.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/editor/create-editor.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/editor/get-expression.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/editor/get-token-location.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/editor/index.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/editor/source-documents.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/editor/source-editor.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/editor/source-search.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/editor/token-events.js /home/mitch/dev/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/utils/editor"
 0:04.85 Executing "/home/mitch/.mozbuild/node/bin/node /home/mitch/dev/firefox/devtools/client/shared/build/build.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/index.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/why.js /home/mitch/dev/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/utils/pause"
 0:04.89 Executing "/home/mitch/.mozbuild/node/bin/node /home/mitch/dev/firefox/devtools/client/shared/build/build.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/frames/annotateFrames.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/frames/collapseFrames.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/frames/displayName.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/frames/getFrameUrl.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/frames/getLibraryFromUrl.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/frames/index.js /home/mitch/dev/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/utils/pause/frames"
 0:04.94 Executing "/home/mitch/.mozbuild/node/bin/node /home/mitch/dev/firefox/devtools/client/shared/build/build.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/mapScopes/buildGeneratedBindingList.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/mapScopes/filtering.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/mapScopes/findGeneratedBindingFromPosition.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/mapScopes/getApplicableBindingsForOriginalPosition.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/mapScopes/index.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/mapScopes/locColumn.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/mapScopes/mappingContains.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/mapScopes/optimizedOut.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/mapScopes/positionCmp.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/mapScopes/rangeMetadata.js /home/mitch/dev/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/utils/pause/mapScopes"
 0:05.02 Executing "/home/mitch/.mozbuild/node/bin/node /home/mitch/dev/firefox/devtools/client/shared/build/build.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/scopes/getScope.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/scopes/getVariables.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/scopes/index.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/pause/scopes/utils.js /home/mitch/dev/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/utils/pause/scopes"
 0:05.11 Executing "/home/mitch/.mozbuild/node/bin/node /home/mitch/dev/firefox/devtools/client/shared/build/build.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/resource/base-query.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/resource/compare.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/resource/core.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/resource/index.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/resource/memoize.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/resource/query-cache.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/resource/query.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/resource/selector.js /home/mitch/dev/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/utils/resource"
 0:05.19 Executing "/home/mitch/.mozbuild/node/bin/node /home/mitch/dev/firefox/devtools/client/shared/build/build.js /home/mitch/dev/firefox/devtools/client/debugger/src/workers/parser/index.js /home/mitch/dev/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/workers/parser"
 0:05.21 Executing "/home/mitch/.mozbuild/node/bin/node /home/mitch/dev/firefox/devtools/client/shared/build/build.js /home/mitch/dev/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/workers"
 0:05.24 Executing "/home/mitch/.mozbuild/node/bin/node /home/mitch/dev/firefox/devtools/client/shared/build/build.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/sources-tree/addToTree.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/sources-tree/collapseTree.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/sources-tree/formatTree.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/sources-tree/getDirectories.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/sources-tree/getURL.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/sources-tree/index.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/sources-tree/sortTree.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/sources-tree/treeOrder.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/sources-tree/updateTree.js /home/mitch/dev/firefox/devtools/client/debugger/src/utils/sources-tree/utils.js /home/mitch/dev/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/utils/sources-tree"
...

Unfortunately, file_generate isn't aware of log levels, and propagating that information through the make step is a challenge for another time.
The ./mach artifact install step is significantly more terse now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d96b1e4199a2
Changes most artifact-build logs from INFO to DEBUG r=rstewart

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d96b1e4199a2