Closed Bug 1646216 Opened 5 years ago Closed 5 years ago

The main thread can, in theory, commit partially-composited content to the screen

Categories

(Core :: Widget: Cocoa, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

The compositor / renderer thread puts stuff on the screen by mutating NativeLayers and then calling NativeLayerRoot::CommitToScreen().
The main thread also calls NativeLayerRoot::CommitToScreen() sometimes.
In theory, this has the potential to happen in the middle of a composition. At that point, the state of the window's NativeLayers would be inconsistent.

We should stop the main thread from committing in the middle of a composition.

Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/36d317f35ab3 Don't call CommitToScreen() on the main thread while another thread is compositing. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: