1646224 - Use mozilla::Length rather than nscoord to store font sizes.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

This is the last usage of nscoord in nsStyleStruct (except for border / outline widths and such which round to device pixels).

This is relevant because I was poking to change AppUnitsPerCssPixel to return 64, but that causes some precision loss when computing EM units and such which is not necessary.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1646224 - Use mozilla::Length rather than nscoord to store font sizes. r=heycam,jfkthame

This avoids arbitrary precision loss when computing REM units and so on,
which is particularly important if we ever change the base of our app
units (but useful regardless).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/299e19193e11
Use mozilla::Length rather than nscoord to store font sizes. r=heycam,jfkthame

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3c62c6802c9
Backed out changeset 299e19193e11 for causing font related failures. CLOSED TREE

Comment 4

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=299e19193e11d8a8e40279d86b45fa189e9b8710&selectedTaskRun=DruOA_OUSOyVOaE33uYsRA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=306787700&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=306787081&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=306787095&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=306788097&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/d3c62c6802c9

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a13c7744245
Use mozilla::Length rather than nscoord to store font sizes. r=heycam,jfkthame

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b90a668d05e1
Fix a typo in windows-only code.

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7a13c7744245
https://hg.mozilla.org/mozilla-central/rev/b90a668d05e1