Closed Bug 164623 Opened 22 years ago Closed 22 years ago

xml.cgi - attachments is broken and insiders not enforced

Categories

(Bugzilla :: User Interface, defect)

Product:
Bugzilla
Component:
User Interface
Version:
2.17
Platform:
x86
Other
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.18

People

(Reporter: bugreport, Assigned: bugreport)

Details

Attachments

(1 file)

Fix
5.57 KB, patch
bbaetz
: review+
bbaetz
: review+
Details | Diff | Splinter Review 
xml.cgi never prints an attachment and does not check isprivate
Attached patch Fix — — Splinter Review 

    
    

    
  
Comment on attachment 96679 [details] [diff] [review]
Fix

I don't see which line here fixes attachments (which aren't showing at all,
currently)

Also, you can drop the regexp for $date, since the db now formats that in
YYYY-MM-DD HH:MM:SS tome (since I changed the datatype a few weeks back)
Target Milestone: --- → Bugzilla 2.18

    
    

    
  
Comment on attachment 96679 [details] [diff] [review]
Fix

Joel pointed out the change to me (move the code outside the if for $date)

r=bbaetz x2 if you remove the condition and resulting regexp entirely (its no
longer needed)

        Attachment #96679 -
        Flags: review+

    
    

    
  
Checking in Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.18; previous revision: 1.17
done

Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: