1646263 - Introduce a lock in CompositorAnimationStorage regardless of whether the backend is WebRender or not

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

I'd like to do this separately from bug 1467765. And for WebRender I am going to introduce a sampler class having a reference of an CompositorAnimationStorage (owned by CompositorBridgeParent) and will have another lock for the CompositorAnimationStorage and provides various functions wrapping CompositorAnimationStorage's methods.

The goals here are;

1. All public methods of CompositorAnimationStorage need to acquire the lock
2. All the other methods should be private and have a AssertCurrentThreadOwns call to make sure it gets called on the same thread where the public methods are called

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1646263 - Drop nsTArray.h from APZSampler.h. r?kats

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1646263 - Use a proper name for NS_NewRunnableFunction in APZSampler. r?kats

Depends on D79942

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1646263 - Separate CompositorAnimationStorage from AnimationHelper.[cpp,h]. r?kats

Depends on D79943

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1646263 - Move the WebRender version of AnimationHelper::SampleAnimations into CompositorAnimationStorage. r?kats

Depends on D79944

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1646263 - Add CompositorAnimationStorage::CollectWebRenderAnimations. r?kats

Depends on D79945

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1646263 - Move the non WebRender version of SampleAnimations into CompositorAnimationStorage. r?kats

Depends on D79946

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1646263 - Make internal-only methods of CompositorAnimationStorage private. r?kats

Depends on D79947

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1646263 - Introduce a lock in CompositorAnimationStorage. r?kats

Depends on D79948

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5af581c74d4b
Drop nsTArray.h from APZSampler.h. r=kats
https://hg.mozilla.org/integration/autoland/rev/c270926a8abd
Use a proper name for NS_NewRunnableFunction in APZSampler. r=kats
https://hg.mozilla.org/integration/autoland/rev/e141e68a3f81
Separate CompositorAnimationStorage from AnimationHelper.[cpp,h]. r=kats
https://hg.mozilla.org/integration/autoland/rev/a7100d508ee2
Move the WebRender version of AnimationHelper::SampleAnimations into CompositorAnimationStorage. r=kats
https://hg.mozilla.org/integration/autoland/rev/a42890da3bb9
Add CompositorAnimationStorage::CollectWebRenderAnimations. r=kats
https://hg.mozilla.org/integration/autoland/rev/68a63d9b0f1b
Move the non WebRender version of SampleAnimations into CompositorAnimationStorage. r=kats
https://hg.mozilla.org/integration/autoland/rev/8dc5e1f8a732
Make internal-only methods of CompositorAnimationStorage private. r=kats
https://hg.mozilla.org/integration/autoland/rev/298a43997d22
Introduce a lock in CompositorAnimationStorage. r=kats

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5af581c74d4b
https://hg.mozilla.org/mozilla-central/rev/c270926a8abd
https://hg.mozilla.org/mozilla-central/rev/e141e68a3f81
https://hg.mozilla.org/mozilla-central/rev/a7100d508ee2
https://hg.mozilla.org/mozilla-central/rev/a42890da3bb9
https://hg.mozilla.org/mozilla-central/rev/68a63d9b0f1b
https://hg.mozilla.org/mozilla-central/rev/8dc5e1f8a732
https://hg.mozilla.org/mozilla-central/rev/298a43997d22