Introduce a lock in CompositorAnimationStorage regardless of whether the backend is WebRender or not
Categories
(Core :: Graphics, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(8 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
I'd like to do this separately from bug 1467765. And for WebRender I am going to introduce a sampler class having a reference of an CompositorAnimationStorage (owned by CompositorBridgeParent) and will have another lock for the CompositorAnimationStorage and provides various functions wrapping CompositorAnimationStorage's methods.
The goals here are;
- All public methods of CompositorAnimationStorage need to acquire the lock
- All the other methods should be private and have a AssertCurrentThreadOwns call to make sure it gets called on the same thread where the public methods are called
Assignee | ||
Comment 1•8 months ago
|
||
Assignee | ||
Comment 2•8 months ago
|
||
Depends on D79942
Assignee | ||
Comment 3•8 months ago
|
||
Depends on D79943
Assignee | ||
Comment 4•8 months ago
|
||
Depends on D79944
Assignee | ||
Comment 5•8 months ago
|
||
Depends on D79945
Assignee | ||
Comment 6•8 months ago
|
||
Depends on D79946
Assignee | ||
Comment 7•8 months ago
|
||
Depends on D79947
Assignee | ||
Comment 8•8 months ago
|
||
Depends on D79948
Pushed by hikezoe.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5af581c74d4b Drop nsTArray.h from APZSampler.h. r=kats https://hg.mozilla.org/integration/autoland/rev/c270926a8abd Use a proper name for NS_NewRunnableFunction in APZSampler. r=kats https://hg.mozilla.org/integration/autoland/rev/e141e68a3f81 Separate CompositorAnimationStorage from AnimationHelper.[cpp,h]. r=kats https://hg.mozilla.org/integration/autoland/rev/a7100d508ee2 Move the WebRender version of AnimationHelper::SampleAnimations into CompositorAnimationStorage. r=kats https://hg.mozilla.org/integration/autoland/rev/a42890da3bb9 Add CompositorAnimationStorage::CollectWebRenderAnimations. r=kats https://hg.mozilla.org/integration/autoland/rev/68a63d9b0f1b Move the non WebRender version of SampleAnimations into CompositorAnimationStorage. r=kats https://hg.mozilla.org/integration/autoland/rev/8dc5e1f8a732 Make internal-only methods of CompositorAnimationStorage private. r=kats https://hg.mozilla.org/integration/autoland/rev/298a43997d22 Introduce a lock in CompositorAnimationStorage. r=kats
Comment 10•7 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5af581c74d4b
https://hg.mozilla.org/mozilla-central/rev/c270926a8abd
https://hg.mozilla.org/mozilla-central/rev/e141e68a3f81
https://hg.mozilla.org/mozilla-central/rev/a7100d508ee2
https://hg.mozilla.org/mozilla-central/rev/a42890da3bb9
https://hg.mozilla.org/mozilla-central/rev/68a63d9b0f1b
https://hg.mozilla.org/mozilla-central/rev/8dc5e1f8a732
https://hg.mozilla.org/mozilla-central/rev/298a43997d22
Description
•