Closed Bug 1646263 Opened 8 months ago Closed 7 months ago

Introduce a lock in CompositorAnimationStorage regardless of whether the backend is WebRender or not

Categories

(Core :: Graphics, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(8 files)

I'd like to do this separately from bug 1467765. And for WebRender I am going to introduce a sampler class having a reference of an CompositorAnimationStorage (owned by CompositorBridgeParent) and will have another lock for the CompositorAnimationStorage and provides various functions wrapping CompositorAnimationStorage's methods.

The goals here are;

  1. All public methods of CompositorAnimationStorage need to acquire the lock
  2. All the other methods should be private and have a AssertCurrentThreadOwns call to make sure it gets called on the same thread where the public methods are called
Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5af581c74d4b
Drop nsTArray.h from APZSampler.h. r=kats
https://hg.mozilla.org/integration/autoland/rev/c270926a8abd
Use a proper name for NS_NewRunnableFunction in APZSampler. r=kats
https://hg.mozilla.org/integration/autoland/rev/e141e68a3f81
Separate CompositorAnimationStorage from AnimationHelper.[cpp,h]. r=kats
https://hg.mozilla.org/integration/autoland/rev/a7100d508ee2
Move the WebRender version of AnimationHelper::SampleAnimations into CompositorAnimationStorage. r=kats
https://hg.mozilla.org/integration/autoland/rev/a42890da3bb9
Add CompositorAnimationStorage::CollectWebRenderAnimations. r=kats
https://hg.mozilla.org/integration/autoland/rev/68a63d9b0f1b
Move the non WebRender version of SampleAnimations into CompositorAnimationStorage. r=kats
https://hg.mozilla.org/integration/autoland/rev/8dc5e1f8a732
Make internal-only methods of CompositorAnimationStorage private. r=kats
https://hg.mozilla.org/integration/autoland/rev/298a43997d22
Introduce a lock in CompositorAnimationStorage. r=kats
You need to log in before you can comment on or make changes to this bug.