1646358 - [socket process] Fix test failures regarding devtool tests

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Kershaw Chang [:kershaw]]

When nsHttpActivityDistributor::ObserveActivityWithArgs is called from socket process parent, we are already on min thread. There is no need to dispatch again at here.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1646358 - Remove unnecessary main thread dispatch, r=dragana

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1646358 - Make sure remote address is available at the right time

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1646358 - Calculate request size in parent process

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Bug 1646358 - Update transfer size in OnDataAvailable

Depends on D81976

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Bug 1646358 - Only set 'Alt-Used' when the header is not empty

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/059a823032d2
Make sure remote address is available at the right time r=dragana
https://hg.mozilla.org/integration/autoland/rev/91fce3e27eac
Calculate request size in parent process r=dragana
https://hg.mozilla.org/integration/autoland/rev/aa32d2fc1762
Update transfer size in OnDataAvailable r=dragana
https://hg.mozilla.org/integration/autoland/rev/f7ebad48e890
Remove unnecessary main thread dispatch, r=dragana
https://hg.mozilla.org/integration/autoland/rev/432a56d9e68e
Only set 'Alt-Used' when the header is not empty r=dragana

Comment 7

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=SCnSGQWdSFK7niFfg0rO4Q.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=5b9d0bc4a6311f9a144b16279790d7b496701058&failure_classification_id=2

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309721740&repo=autoland&lineNumber=1878
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309720516&repo=autoland&lineNumber=2124
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309721737&repo=autoland&lineNumber=1886
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309720452&repo=autoland&lineNumber=18948

Backout: https://hg.mozilla.org/integration/autoland/rev/344cc585200c0bb4066fd6f02d2b4942071b7c00

Comment 8

[Kershaw Chang [:kershaw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e83802a452ee18f82319abaef8ba703251876256&selectedTaskRun=FsR9x_AEQke-Jv0vjfN2xA.0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86ad7016b9ab
Make sure remote address is available at the right time r=dragana
https://hg.mozilla.org/integration/autoland/rev/7a20841b3834
Calculate request size in parent process r=dragana
https://hg.mozilla.org/integration/autoland/rev/0eb38daa2b66
Update transfer size in OnDataAvailable r=dragana
https://hg.mozilla.org/integration/autoland/rev/a28eb84718a6
Remove unnecessary main thread dispatch, r=dragana
https://hg.mozilla.org/integration/autoland/rev/7997a98be55e
Only set 'Alt-Used' when the header is not empty r=dragana

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/86ad7016b9ab
https://hg.mozilla.org/mozilla-central/rev/7a20841b3834
https://hg.mozilla.org/mozilla-central/rev/0eb38daa2b66
https://hg.mozilla.org/mozilla-central/rev/a28eb84718a6
https://hg.mozilla.org/mozilla-central/rev/7997a98be55e