1646405 - vendor PyYAML for real

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1646405 - Rename pyyaml to PyYAML for vendering r?ahal

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1646405 - update the code using pyyaml to use the new path r?ahal

Depends on D80022

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1646405 - Vendor PyYAML 5.3.1 r?ahal

Depends on D80025

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1646405 - Vendor pathspec 0.8 r?ahal

Depends on D80026

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1646405 - Vendor yamllint r?ahal

Depends on D80028

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/747b210d4e71
Rename pyyaml to PyYAML for vendering r=ahal
https://hg.mozilla.org/integration/autoland/rev/944b1d37808f
update the code using pyyaml to use the new path r=ahal
https://hg.mozilla.org/integration/autoland/rev/3f969fd8c424
Vendor PyYAML 5.3.1 r=ahal
https://hg.mozilla.org/integration/autoland/rev/cf2d57addb51
Vendor pathspec 0.8 r=ahal
https://hg.mozilla.org/integration/autoland/rev/8bd9ad543d4a
Vendor yamllint r=ahal

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/747b210d4e71
https://hg.mozilla.org/mozilla-central/rev/944b1d37808f
https://hg.mozilla.org/mozilla-central/rev/3f969fd8c424
https://hg.mozilla.org/mozilla-central/rev/cf2d57addb51
https://hg.mozilla.org/mozilla-central/rev/8bd9ad543d4a

Comment 8

[Peter Van der Beken [:peterv]]

I'll note that the renaming of third_party/python/pyyaml to third_party/python/PyYAML didn't get picked up when I did a hg pull on OS X (probably because of the case-insensitive filesystem). I rsync my tree to linux from OS X and it broke my build (couldn't find the yaml module). I had to manually delete third_party/python/pyyaml and then hg revert -a to get it to do the rename.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Arf, désolé Peter :(

Comment 10

[Peter Van der Beken [:peterv]]

Yeah, no worries. I thought I'd mention it, maybe it'll help someone else if they run into the same issue. It's pretty annoying that hg doesn't pick up the change correctly.

Comment 11

[Nathan Froyd [:froydnj]]

We have lints in place for that sort of thing for mingw header files; I guess we should extend it to more things. :(