Closed Bug 1646405 Opened 3 months ago Closed 3 months ago

vendor PyYAML for real

Categories

(Firefox Build System :: Lint and Formatting, task)

task

Tracking

(firefox79 fixed)

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(5 files)

No description provided.
Assignee: nobody → sledru
Status: NEW → ASSIGNED

Depends on D80025

Depends on D80026

Depends on D80028

I'll note that the renaming of third_party/python/pyyaml to third_party/python/PyYAML didn't get picked up when I did a hg pull on OS X (probably because of the case-insensitive filesystem). I rsync my tree to linux from OS X and it broke my build (couldn't find the yaml module). I had to manually delete third_party/python/pyyaml and then hg revert -a to get it to do the rename.

Arf, désolé Peter :(

Yeah, no worries. I thought I'd mention it, maybe it'll help someone else if they run into the same issue. It's pretty annoying that hg doesn't pick up the change correctly.

We have lints in place for that sort of thing for mingw header files; I guess we should extend it to more things. :(

You need to log in before you can comment on or make changes to this bug.