1646406 - Distinguish more robustly between user errors and actual exceptions that we should report on in mach

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task)

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

It looks like we already have a bit of infrastructure in-place for differentiating between a script that unexpectedly broke (except Exception) and a slightly-more-expected exception (except FailedCommandError).

It's also worth noting that we have two high-level exception handlers:

• One in Mach.run()
• One in Mach._run()

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Ricky and I discussed this a little bit in our one-to-one meeting today:

• We can create a new top-level UserError (or something similarly named) that, when handled, simply prints the message and exits without reporting the error to Sentry or printing the "mach busted" text
• This error will be used to replace all cases where we to tell the user via an exception that "we can't proceed until <x> happens".

Comment 3

[Ricky Stewart]

Attachment: Bug 1646406 - Distinguish between user errors and actual reportable exceptions in `mach`

Add a new UserError class which when thrown doesn't get reported to Sentry.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18d42084d135
Distinguish between user errors and actual reportable exceptions in `mach` r=mhentges,froydnj

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1655529 - please see https://bugzilla.mozilla.org/show_bug.cgi?id=1655529#c3

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0e293063894
Backed out 2 changesets (bug 1646406, bug 1655529) for geckoview failures. CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ae4af0ee490
Distinguish between user errors and actual reportable exceptions in `mach` r=mhentges,froydnj

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2ae4af0ee490