1646421 - Update to flake8 3.8.3

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

For some reason, we were removing the exclude from the config causing this issue:

Traceback (most recent call last):
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/python/mozlint/mozlint/roller.py", line 60, in _run_worker
    res = func(paths, config, **lintargs) or []
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/python/mozlint/mozlint/types.py", line 54, in __call__
    return self._lint(paths, config, **lintargs)
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/python/mozlint/mozlint/types.py", line 139, in _lint
    return func(files, config, **lintargs)
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/tools/lint/python/flake8.py", line 147, in lint
    app.run(flake8_cmd)
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/lib/python3.8/site-packages/flake8/main/application.py", line 361, in run
    self._run(argv)
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/lib/python3.8/site-packages/flake8/main/application.py", line 348, in _run
    self.initialize(argv)
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/lib/python3.8/site-packages/flake8/main/application.py", line 336, in initialize
    self.make_file_checker_manager()
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/tools/lint/python/flake8.py", line 138, in wrap_make_file_checker_manager
    return orig_make_file_checker_manager()
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/lib/python3.8/site-packages/flake8/main/application.py", line 242, in make_file_checker_manager
    self.file_checker_manager = checker.Manager(
  File "/home/sylvestre/dev/mozilla/mozilla-central.hg/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/lib/python3.8/site-packages/flake8/checker.py", line 101, in __init__
    self.exclude = tuple(
TypeError: 'NoneType' object is not iterable

sharing for posterity

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1646421 - mozlint/flake8 remove the force-removal of the exclude list r?#linter-reviewers

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1646421 - Update to flake8 3.8.3 (requires toml now) r?#linter-reviewers

Depends on D80075

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1646421 - flake8 Fix a bunch of actual errors r?ahal

Depends on D80076

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ae78b035260
mozlint/flake8 remove the force-removal of the exclude list r=linter-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/a1d73ef3c7ee
Update to flake8 3.8.3 (requires toml now) r=linter-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/797a96210c41
flake8 Fix a bunch of actual errors r=ahal

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1646421 - flake8 followup, remove the noqa as it breaks the test r=me

Instead, ignore this specific test for this file

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2875207c0a74
flake8 followup, remove the noqa as it breaks the test

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8ae78b035260
https://hg.mozilla.org/mozilla-central/rev/a1d73ef3c7ee
https://hg.mozilla.org/mozilla-central/rev/797a96210c41
https://hg.mozilla.org/mozilla-central/rev/2875207c0a74