164648 - XprintUtils does not handle non-space "whitespace-like" seperators in ${XPSERVERLIST} correctly

Status: RESOLVED FIXED

(Core Graveyard :: Printing: Xprint, defect)

Description

[Roland Mainz]

XprintUtils doesn't like non-space "whitespace-like" seperators in
${XPSERVERLIST}

Example:
x=$(echo "foo\nbar") ; echo $x # looks like "foo bar" in a terminal window but
the seperator between "foo" and "bar" is still a newline.
The current XprintUtil code doesn't handle this issue... ;-(

IMHO we should support (at least) space, alternate-space, TAB, vertical TAB and
newline.

Comment 1

[Roland Mainz]

Swapping QA<---->Owner...

Comment 2

[Roland Mainz]

Attachment: Patch for 2002-09-14-08-trunk

Comment 3

[Roland Mainz]

Requesting r=/sr= ...

Comment 4

[Roland Mainz]

Filed http://xprint.mozdev.org/bugs/show_bug.cgi?id=2147 to track this issue for
the XprintUtil copy in xprint.mozdev.org's source tree...

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 99313 [details] [diff] [review]
Patch for 2002-09-14-08-trunk

r=bbaetz, since roland tells me that X11's equivalent of this handles this via
isspace.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Change XPSERVERLIST_SEPERATORS to something like this:
static const char XPServerListSeparators[] = ...;
(It's type safe, and saves space on some compilers)

and then sr=roc+moz

Comment 7

[Roland Mainz]

Attachment: New patch for 2002-09-29-08-trunk per roc-moz's superreview comments

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 102003 [details] [diff] [review]
New patch for 2002-09-29-08-trunk per roc-moz's superreview comments

sr=roc+moz
r=bbaetz

Comment 9

[Simon Montagu :smontagu]

Fix checked in.

Comment 10

[Kris Maglione [:kmag]]

Attachment: Bug 164648: Stop using GetInProcessParentDocument in DoSecureToInsecureSubmitCheck. r=nika

Comment 11

[Phabricator Automation]

Comment on attachment 9157418 [details]
Bug 164648: Stop using GetInProcessParentDocument in DoSecureToInsecureSubmitCheck. r=nika

Revision D80068 was moved to bug 1646482. Setting attachment 9157418 [details] to obsolete.