1646514 - Speedup test generation by reusing the loader instead of new instances

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, enhancement)

Description

[Justin Wood (:Callek)]

The method get_manifests on the test loader is memoized which should speed it up, however memoize caches on the instance of the class rather than globally. Thus the fact that we recreate the class instance for each task is suboptimal.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1646514: Use a single manifest loader for all tests; r?ahal

Since @memoize on a method is per-instance, use a single instance for all
tests, rather than a new one for each tasks. This gives a ~4x speedup in test
task generation.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ef0dbc432ba
Use a single manifest loader for all tests; r=Callek

Comment 3

[Andrew Halberstadt [:ahal]]

Dope, thanks for noticing and fixing. The instance used to be stored on the registry, so the regression was a bit subtle.

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6ef0dbc432ba