Closed Bug 1646537 Opened 3 years ago Closed 3 years ago

Use BrowsingContext (and IPC) in place of GetInProcessParent usage in nsGlobalWindowOuter::FocusOuter

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Project Flags:
Fission Milestone M6b
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: kmag, Assigned: hsivonen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1646537 - Use BrowsingContext (and IPC) in place of GetInProcessParent usage in nsGlobalWindowOuter::FocusOuter.
47 bytes, text/x-phabricator-request
Details | Review

It probably doesn't do the right thing when the parent window is in a different process, but that case may be handled elsewhere.

Severity: -- → N/A

Tracking "Figure out GetInProcessTop usage" bugs for Fission M6b.

Fission Milestone: --- → M6b
Flags: needinfo?(hsivonen)

I believe we need to obtain the parent BrowsingContext and, if it is out-of-process, request the relevant next steps to run in the process where that BrowsingContext resides.

Type: task → defect
Flags: needinfo?(hsivonen)
Summary: Figure out if GetInProcessParent usage in nsGlobalWindowOuter::FocusOuter is OK → Use BrowsingContext (and IPC) in place of GetInProcessParent usage in nsGlobalWindowOuter::FocusOuter
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED

As I iterate on this more, my new Fission code ends up doing the same thing that the e10s code was already doing--also in Fission--so maybe this whole patch is unnecessary... But let's try making the code look consistent between in-process and out-out-process iframes even if the patch ends up being pretty much a no-op really.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b36940eb86044465de379701bf76c21297e8465

If I'm reading treeherder right, the remaining oranges are known tier-2 permaoranges.

Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd3fdb184761
Use BrowsingContext (and IPC) in place of GetInProcessParent usage in nsGlobalWindowOuter::FocusOuter. r=nika

https://hg.mozilla.org/mozilla-central/rev/cd3fdb184761

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.