1646547 - Figure out if GetInProcessParentDocument usage in ScriptLoader::ReadyToExecuteParserBlockingScripts is OK

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Kris Maglione [:kmag]]

It walks the entire ancestor chain and returns false if any of them are not ready to execute parser blocking scripts, but stops any time it encounters an OOP ancestor. It should probably at least walk all in-process ancestor documents regardless of OOP interstitials, but I'm not sure how much it matters in practice.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking "Figure out GetInProcessTop usage" bugs for Fission M6b.

Comment 2

[Neha Kochar [:neha]]

Baku or Henri, I'm hoping one of you is the right person to review this usage?

Comment 3

[Andrea Marchesini [:baku]]

Jon, do you have time to take a look?

Comment 4

[Jon Coppeard (:jonco)]

I don't understand this enough to usefully review it.

Comment 5

[Henri Sivonen (:hsivonen)]

This exists in order to fix bug 383331. I don't know how much it matters in practice, but the suggestions from comment 0 seems prudent and reasonable.

Comment 6

[Neha Kochar [:neha]]

Steven, you can ask kmag for more context, if you need.

Comment 7

[Steven MacLeod [:smacleod]]

Attachment: Bug 1646547 - fix ScriptLoader::ReadyToExecuteParserBlockingScripts stopping at OOP ancestors. r?kmag

ReadyToExecuteParserBlockingScripts was walking the ancestor chain but
would stop if it hit an OOP ancestor. With this change we walk the
BrowsingContext tree instead, so that we may skip over OOP ancestors
and continue checking all in process ancestors.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72c9cdfb1049
fix ScriptLoader::ReadyToExecuteParserBlockingScripts stopping at OOP ancestors. r=kmag

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/72c9cdfb1049