1646562 - Fix GetInProcessParentDocshell usage in nsDocShell::RestoreFromHistory

Status: NEW

(Core :: DOM: Navigation, defect, P3)

Description

[Kris Maglione [:kmag]]

It's used to suppress event handling when it's suppressed in its parent, though that currently does not work for OOP ancestors/descendants or hierarchies with OOP interstitials either way.

Comment 1

[Chris Peterson [:cpeterson]]

Fission Future because this code is only used in bfcache.

Comment 2

[Neha Kochar [:neha]]

Olli, can you review and figure out if this will be done as part of BFCache Fission redesign or will we need this on file to fix after the initial implementation is done?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

This shouldn't be needed at all, but keeping this open for now.

Comment 4

[Kris Maglione [:kmag]]

Agree with comment 3. This should only be called for top-level docshells, which can't have an in-process parent under Fission anyway, so it shouldn't matter.

Comment 5

[Neha Kochar [:neha]]

We may end up removing this altogether, so bringing back Fission milestone (although not M7) so that we can close this bug when we do that.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

This probably doesn't need to block Fission at all. The code is for in-process bfcache, not for parent process bfcache.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

This doesn't need to block Fission at all.