Closed Bug 1646563 Opened 5 years ago Closed 5 years ago

Simplify how we handle BrowserIds on frame elements

Categories

(Core :: DOM: Content Processes, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla79
Fission Milestone M7
Tracking Status
firefox79 --- fixed

People

(Reporter: u608768, Assigned: u608768)

References

Details

Attachments

(1 file)

The logic added in bug 1580766 is unnecessarily complicated. The code already handles copying BrowserIds between BrowsingContexts during frame loader swaps, so we don't need to manually manage a separate BrowserId field on the FrameLoaderOwner.

We can just use BrowsingContext::BrowserId directly, so this adds unnecessary
complexity.

This also makes it so that we only ever generated BrowserIds in
BrowsingContext::CreatedDetached.

Pushed by kmadan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/95b350572bbf Remove BrowserId from nsFrameLoaderOwner, r=nika
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Regressions: 1652397
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: