1646568 - Fix GetInProcessParentDocshell usage in nsDocShell::InFrameSwap

Status: RESOLVED WORKSFORME

(Core :: DOM: Navigation, defect, P3)

Comment 1

[Chris Peterson [:cpeterson]]

Emilio, is this code broken for Fission OOP iframes? Do we need to fix this before we enable Fission?

InFrameSwap() was added in requestAnimationFrame bug 1578379. It's only called in MOZ_DIAGNOSTIC_ASSERTs in OnPageShow() and OnPageHide().

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I think we don't need to do fancies to swap remote browsers. That code would already be broken in e10s. Frame-swapping works fine in fission so I think this is WFM.

We probably need to make sure that we don't fire any pageshow / pagehide events on cross-origin iframes and so on before closing this though.

Comment 3

[Neha Kochar [:neha]]

Moving to MVP based on comment 2 as it's not nightly or beta blocking.

Comment 4

[Neha Kochar [:neha]]

Let's confirm and do any needful fixes before going to release (M8).

Comment 5

[Nika Layzell [:nika] (ni? for response)]

I'm pretty sure this call site is OK as it is no different now with Fission, and shouldn't have any impact here. The pageshow and pagehide events fired here are fired with aOnlySystemGroup = true, meaning that they can't be observed by web content, so we definitely shouldn't run into any issues here.