Closed Bug 1646569 Opened 9 months ago Closed 9 months ago

Remove SearchService init console log

Categories

(Firefox :: Search, task, P4)

task

Tracking

()

RESOLVED FIXED
Firefox 79
Tracking Status
firefox79 --- fixed

People

(Reporter: daleharvey, Assigned: a.park0324, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This gets called by every async caller of the SearchService and so fills up the console while not being very useful for debugging

https://searchfox.org/mozilla-central/source/toolkit/components/search/SearchService.jsm#498-499

So it should just be removed? I can take this one

Dumb question (I'm new), but where exactly is it logging the messages? Is it directly to console? I don't see the messages in the console or in the terminal where I'm running my build. Thanks for your help

Assignee: nobody → a.park0324
Status: NEW → ASSIGNED

It logs in the shell and in the browser console, but needs browser.search.log.enabled=true before it shows up, thanks for the patch :)

Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e0776cdbf05
Remove SearchService console log. r=daleharvey
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

Ah ok, I see it now that I set the pref. Thanks for the info and review

Since we can not manually verify this issue I will mark it as qe-.

Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.