Remove SearchService init console log
Categories
(Firefox :: Search, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: daleharvey, Assigned: a.park0324, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
This gets called by every async caller of the SearchService and so fills up the console while not being very useful for debugging
https://searchfox.org/mozilla-central/source/toolkit/components/search/SearchService.jsm#498-499
|
Assignee | |
Comment 1•9 months ago
|
||
So it should just be removed? I can take this one
|
|
Assignee | |
Comment 2•9 months ago
|
||
Dumb question (I'm new), but where exactly is it logging the messages? Is it directly to console? I don't see the messages in the console or in the terminal where I'm running my build. Thanks for your help
|
|
Assignee | |
Comment 3•9 months ago
|
||
|
||
Updated•9 months ago
|
|
Reporter | |
Comment 4•9 months ago
|
||
It logs in the shell and in the browser console, but needs browser.search.log.enabled=true before it shows up, thanks for the patch :)
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e0776cdbf05 Remove SearchService console log. r=daleharvey
|
||
Comment 6•9 months ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 7•9 months ago
|
||
Ah ok, I see it now that I set the pref. Thanks for the info and review
|
||
Comment 8•9 months ago
|
||
Since we can not manually verify this issue I will mark it as qe-.
Description
•