1646614 - [wpt-sync] Sync PR 24224 - [FlexNG] Multiplying by aspect ratio should ignore border/padding

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24224 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24224
Details from upstream follow.

David Grogan <[e-mail]> wrote:

[FlexNG] Multiplying by aspect ratio should ignore border/padding

Only the content box should be multiplied by the aspect ratio to derive
the size of a side given the other side and the aspect ratio.

So, subtract the border/padding from the side you have, then multiply to
get the content size, then add that side's border/padding.

Bug: 1094311
Change-Id: Ib69a224cdb369c3fa46f5d432af73eb131781673
Reviewed-on: https://chromium-review.googlesource.com/2251202
WPT-Export-Revision: c56cd35a1fde481bffa505a37952d7e4c98c0401

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2073d5aea8583107b1aa0f93d1ec396bbbd2cf4

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
PASS: 4

Chrome

OK : 1
FAIL: 4

Safari

OK : 1
PASS: 3
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2beded47c0dc
[wpt PR 24224] - [FlexNG] Multiplying by aspect ratio should ignore border/padding, a=testonly

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2beded47c0dc