Closed Bug 1646614 Opened 5 months ago Closed 5 months ago

[wpt-sync] Sync PR 24224 - [FlexNG] Multiplying by aspect ratio should ignore border/padding

Categories

(Core :: Layout: Flexbox, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24224 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24224
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[FlexNG] Multiplying by aspect ratio should ignore border/padding

Only the content box should be multiplied by the aspect ratio to derive
the size of a side given the other side and the aspect ratio.

So, subtract the border/padding from the side you have, then multiply to
get the content size, then add that side's border/padding.

Bug: 1094311
Change-Id: Ib69a224cdb369c3fa46f5d432af73eb131781673
Reviewed-on: https://chromium-review.googlesource.com/2251202
WPT-Export-Revision: c56cd35a1fde481bffa505a37952d7e4c98c0401

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
PASS: 4

Chrome

OK : 1
FAIL: 4

Safari

OK : 1
PASS: 3
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2beded47c0dc
[wpt PR 24224] - [FlexNG] Multiplying by aspect ratio should ignore border/padding, a=testonly
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.