1646678 - Add a mechanism to test server-side Resource listener while they're not enabled yet

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

At the moment, the resource listeners we have on the server are disabled, which means we could break them without noticing it, as no test will trigger them.
We should have a mechanism to force the server side support from a given test, and use that at least in the devtools/shared/resources/tests/browser_resources_* tests which have both a legacy and a server listener.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1646678 - Allow resource watcher tests to force server side support. r=jdescottes,ochameau.

This is done by getting the value of the devtools.testing.enableServerWatcherSupport
preference on the WatcherActor, and using its result to enable the traits or not.
On the browser_resources_* test that have both legacy and server listener, we
run the tests twice, without and with the pref to have some decent coverage.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40dae06d5e4d
Allow resource watcher tests to force server side support. r=ochameau.

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 40dae06d5e4d (bug 1646678) for Devtools failures in tests/browser_resources_several_resources.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306814572&repo=autoland&lineNumber=25672

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=40dae06d5e4dc28c1cc66b7980cbc7b0437a0b3b

Backout:
https://hg.mozilla.org/integration/autoland/rev/5acd8c4fc32a960ff0cd9efc62435a167abe42ce

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b09c7ddea2a4
Allow resource watcher tests to force server side support. r=ochameau.

Comment 5

[Cristina Coroiu [:ccoroiu]]

Backed out changeset b09c7ddea2a4 (bug 1646678) for causing leaks

Backout: https://hg.mozilla.org/integration/autoland/rev/d26c7e854d7b15269b56f232d5c39258746c072e

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b09c7ddea2a4f6fd64cbb16e1e93d54c1ec8cf60

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307210879&repo=autoland&lineNumber=27052

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98f3015f9020
Allow resource watcher tests to force server side support. r=ochameau.

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/98f3015f9020