1646701 - HttpTransaction may read data but return 0 bytes read

Status: NEW

(Core :: Networking: HTTP, task, P3)

Description

[Dragana Damjanovic [:dragana]]

Here a transaction reads data from a pipe.
After reading the header part of data it actually moves data in the buffer, so the buffer becomes smaller (here).

So if there are only headers in the stream, the transaction will return the smaller buffer back to the pipe and also 0 bytes read.
The pipe will be happy with this, but some http2 and http3 code (maybe also the http1.1 code paths) rely on the "bytes read", i.e. if it is >0 the transaction has read some data if it is 0 it did not read any data. In the case above the transaction has read headers but it has return 0 bytes.

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: Don't resize a buffer and return 0 bytes read, but instread return exact amount of bytes read. r=mayhemer

Comment 2

[Dragana Damjanovic [:dragana]]

This is how this has always worked. This is not a defect it is intended behavior. We may wan to change it at some point.