1646781 - Visual glitches are observed by the spectators of a screen sharing on talky.io

Status: NEW

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Negritas Sergiu, Desktop QA]

Attachment: screenshare with glitch.webm

Affected versions

• 77.0.1
• 78.0b8
• 79.0a1 (2020-06-18)

Affected platforms

• MacOS 10.15.6

Steps to reproduce

1. Engage in a video-conference call on www.talky.io.
2. Share screen with other participants.
3. Stop screen sharing.
4. Share screen again.

Expected result

• Screen sharing is received by other participants without any visual glitches.

Actual Result

• Receivers in the call are getting a screenshare with visual glitches.

Regression range

• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a77e8f3efc4cb45b7caa0c87879910b9991b4219&tochange=0cf7daf34a373c26eecab2b19baf7bff67756170
• Last good revision: a77e8f3efc4cb45b7caa0c87879910b9991b4219 (2018-12-27)
• First bad revision: 0cf7daf34a373c26eecab2b19baf7bff67756170 (2018-12-28)

Additional notes

• The attachment is showing what happens when you receive the screen sharing from MacOS.

Comment 1

[Dan Minor [:dminor]]

Hi Jan-Ivar, there are a few of your patches in the regression range. Do you mind having a look to see if one of them could be responsible? Thanks!

Comment 2

[Daniel Bodea [:danibodea]]

This issue was also reproduced on Nightly v79.0a1 on Windows 7.
The shared-screen stream shared is showing visual glitches.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

(In reply to Dan Minor [:dminor] from comment #1)

Hi Jan-Ivar, there are a few of your patches in the regression range. Do you mind having a look to see if one of them could be responsible? Thanks!

It's likely this one. 🙂

Jan-Ivar Bruaroey — Bug 1321221 - Implement getDisplayMedia() and update related wpt tests. r=pehrsons,smaug

That's the introduction of the getDisplayMedia screen sharing function. I doubt anything worked before then (unless it was using Firefox's legacy api).

Sergiu, I'm assuming nothing worked before then? Are you able to repro using https://jan-ivar.github.io/dummy/gdm.html ?

Comment 4

[Negritas Sergiu, Desktop QA]

Hello Jan!
Sorry for the long time for responding to this.
I am not able to reproduce the issue using the link you provided with Firefox Nightly 79.0a1(2020-06-26) on MacOS 10.15.6 .

Comment 5

[Daniel Bodea [:danibodea]]

It appears that this issue does not reproduce anymore, on the same test machine is was first observed. Leaving this open for a while, keeping an eye on it while testing webrtc.